Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LoreHolder registration to a later init stage #118

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Move LoreHolder registration to a later init stage #118

merged 2 commits into from
Mar 5, 2025

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Mar 5, 2025 •
edited
Loading

Tested and works fine in 2.7.3 and latest

Closes #106

@Lyfts Lyfts requested a review from a team March 5, 2025 13:35
glowredman
glowredman reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the logging refactor works as intended? Unless I'm mistaken, log4j now treats the exception as formatting substitue.

@Lyfts
Copy link
Member Author

Lyfts commented Mar 5, 2025

Yes I am confident that it works.

@Lyfts Lyfts requested review from glowredman and a team March 5, 2025 13:50
glowredman
glowredman approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seems like I was under a false impression.

@serenibyss serenibyss enabled auto-merge (squash) March 5, 2025 15:44
@serenibyss serenibyss merged commit 1c66f22 into master Mar 5, 2025
1 check passed
@serenibyss serenibyss deleted the later-loreholders branch March 5, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glowredman glowredman glowredman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Game gets stuck at "Sound engine started" after upgrading gtnhlib from 0.6.1 --> 0.6.2 / 0.6.6
3 participants
@Lyfts @glowredman @serenibyss