Add NEI Version Check (#109)

gradle.properties

@@ -176,7 +176,7 @@ curseForgeRelations =
 # This can be useful if you e.g. only want to allow versions in the form of '1.1.xxx'.
 # The check is ONLY performed if the version is a git tag.
 # Note: the specified string must be escaped, so e.g. 1\\.1\\.\\d+ instead of 1\.1\.\d+
-# versionPattern =
+versionPattern = d+\\.d+\\.d+(-pre|-snapshot)?
 
 # Uncomment to prevent the source code from being published.
 # noPublishedSources = true

settings.gradle

@@ -17,7 +17,7 @@ pluginManagement {
 }
 
 plugins {
-    id 'com.gtnewhorizons.gtnhsettingsconvention' version '1.0.31'
+    id 'com.gtnewhorizons.gtnhsettingsconvention' version '1.0.32'
 }
 
 

src/main/java/com/gtnewhorizon/gtnhlib/ClientProxy.java

@@ -13,9 +13,11 @@
 import com.gtnewhorizon.gtnhlib.commands.ItemInHandCommand;
 import com.gtnewhorizon.gtnhlib.compat.FalseTweaks;
 import com.gtnewhorizon.gtnhlib.compat.Mods;
+import com.gtnewhorizon.gtnhlib.compat.NotEnoughItemsVersionChecker;
 import com.gtnewhorizon.gtnhlib.eventbus.EventBusSubscriber;
 import com.gtnewhorizon.gtnhlib.util.AboveHotbarHUD;
 
+import cpw.mods.fml.common.FMLCommonHandler;
 import cpw.mods.fml.common.event.*;
 import cpw.mods.fml.common.eventhandler.SubscribeEvent;
 import cpw.mods.fml.common.gameevent.TickEvent;
@@ -45,6 +47,9 @@ public void postInit(FMLPostInitializationEvent event) {
                 GTNHLib.info("FalseTweaks threaded rendering is enabled - disabling GTNHLib's thread safety checks");
             }
         }
+        if (Mods.NEI) {
+            FMLCommonHandler.instance().bus().register(new NotEnoughItemsVersionChecker());
+        }
 
         if (shouldLoadModels()) {
             Minecraft.getMinecraft().refreshResources();

src/main/java/com/gtnewhorizon/gtnhlib/CommonProxy.java

@@ -4,6 +4,7 @@
 import net.minecraft.util.IChatComponent;
 import net.minecraftforge.common.util.FakePlayer;
 
+import com.gtnewhorizon.gtnhlib.config.ConfigException;
 import com.gtnewhorizon.gtnhlib.config.ConfigurationManager;
 import com.gtnewhorizon.gtnhlib.eventbus.AutoEventBus;
 import com.gtnewhorizon.gtnhlib.eventbus.Phase;
@@ -29,6 +30,11 @@ public void construct(FMLConstructionEvent event) {
     public void preInit(FMLPreInitializationEvent event) {
         AutoEventBus.executePhase(Phase.PRE);
         GTNHLib.info("GTNHLib version " + Tags.VERSION + " loaded.");
+        try {
+            ConfigurationManager.registerConfig(GTNHLibConfig.class);
+        } catch (ConfigException e) {
+            GTNHLib.LOG.error("Failed to register GTNHLib config!", e);
+        }
     }
 
     public void init(FMLInitializationEvent event) {

src/main/java/com/gtnewhorizon/gtnhlib/GTNHLibConfig.java

@@ -0,0 +1,12 @@
+package com.gtnewhorizon.gtnhlib;
+
+import com.gtnewhorizon.gtnhlib.config.Config;
+
+@Config(modid = GTNHLib.MODID)
+public class GTNHLibConfig {
+
+    @Config.Comment("Set to true to no longer check if the NEI version is new enough to support RenderTooltipEvents")
+    @Config.DefaultBoolean(false)
+    public static boolean ignoreNEIVersion;
+
+}

src/main/java/com/gtnewhorizon/gtnhlib/compat/Mods.java

@@ -5,4 +5,5 @@
 public class Mods {
 
     public static final boolean FALSETWEAKS = Loader.isModLoaded("falsetweaks");
+    public static final boolean NEI = Loader.isModLoaded("NotEnoughItems");
 }

src/main/java/com/gtnewhorizon/gtnhlib/compat/NotEnoughItemsVersionChecker.java

@@ -0,0 +1,40 @@
+package com.gtnewhorizon.gtnhlib.compat;
+
+import java.util.Locale;
+
+import com.gtnewhorizon.gtnhlib.GTNHLib;
+import com.gtnewhorizon.gtnhlib.GTNHLibConfig;
+
+import cpw.mods.fml.client.FMLClientHandler;
+import cpw.mods.fml.common.FMLCommonHandler;
+import cpw.mods.fml.common.Loader;
+import cpw.mods.fml.common.eventhandler.SubscribeEvent;
+import cpw.mods.fml.common.gameevent.TickEvent.ClientTickEvent;
+import cpw.mods.fml.common.versioning.ArtifactVersion;
+import cpw.mods.fml.common.versioning.DefaultArtifactVersion;
+
+public class NotEnoughItemsVersionChecker {
+
+    @SubscribeEvent
+    public void checkNEIVersion(ClientTickEvent event) {
+        if (FMLClientHandler.instance().getClient().thePlayer == null) {
+            return;
+        }
+
+        FMLCommonHandler.instance().bus().unregister(this);
+
+        if (GTNHLibConfig.ignoreNEIVersion) {
+            return;
+        }
+
+        ArtifactVersion neiVersion = Loader.instance().getIndexedModList().get("NotEnoughItems").getProcessedVersion();
+        if (neiVersion.compareTo(new DefaultArtifactVersion("2.7.8-GTNH")) >= 0) {
+            return; // NEI is at least version 2.7.8-GTNH
+        }
+        GTNHLib.proxy.addWarnToChat(
+                String.format(
+                        Locale.ROOT,
+                        "Installed NEI version is to old to support RenderTooltipEvents! This may cause problems. Installed NEI version: %s (2.7.8-GTNH and newer support RenderTooltipEvents)",
+                        neiVersion.getVersionString()));
+    }
+}

src/main/java/com/gtnewhorizon/gtnhlib/util/FilesUtil.java

@@ -3,14 +3,16 @@
 import java.io.IOException;
 import java.net.URI;
 
+import net.minecraft.util.Util;
+
 import org.lwjgl.Sys;
 
 import com.gtnewhorizon.gtnhlib.GTNHLib;
 
 public class FilesUtil {
 
     public static void openUri(URI uri) {
-        switch (net.minecraft.util.Util.getOSType()) {
+        switch (Util.getOSType()) {
             case OSX -> {
                 try {
                     Runtime.getRuntime().exec(new String[] { "/usr/bin/open", uri.toString() });