Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate buildscript attempt 3 #9

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

llk89
Copy link

@llk89 llk89 commented Mar 4, 2022

Class Registries are merged together into one. All subprojects are also merged into one. It's probably possible to split stuff into multiple source sets and not merging the registries, but I'm just too lazy for that.

Also removed submodule and used shade instead. It's probably less convenient for anyone that want to improve ZenScript, but before anyone want to do that, this will do.

Class Registries are merged together into one. All subprojects are also merged into one. It's probably possible to split stuff into multiple source sets and not merging the registries, but I'm just too lazy for that.
@Glease Glease requested a review from a team March 4, 2022 19:03
@@ -0,0 +1,5 @@
dependencies {
shadeCompile("com.github.GTNewHorizons:ZenScript:1.0.0-GTNH")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably some kind of editor nonsense.

Copy link
Member

@bombcar bombcar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but so did the last four attempts; did it build and run?

@Dream-Master Dream-Master merged commit bf291de into master Mar 4, 2022
@Dream-Master Dream-Master deleted the feature/unified-buildscript branch March 4, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants