Enable max tier to appear both earlier and at end of tiering #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dream-Master
added
the
🚧 Testing on Zeta
Lyfts
requested changes
Mar 9, 2025
|
|
||
| data.setMaxTier(tier - 1, channel); | ||
| data.setMaxTier(tier, channel); |
There was a problem hiding this comment.
That -1 was there for a reason, this adds an additional tier to every multi which is identical to the previous tier.
There was a problem hiding this comment.
Yeah, I get that. There are some alternatives I've come up with though that might work better, I'd appreciate your thoughts
- Only do this if the previous iteration was different from the last iteration, probably the simplest and (imo) cleanest
- Change how variants work so that explicit tiering is | tier 1 + variants | tier 2 + variants | ... | tier x variants | instead of what I did which is | tier 1 main | tier 2 main | tier 1 variants | tier 2 variants | tier X main |.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports GT5 PR GTNewHorizons/GT5-Unofficial#4032
Makes it so that a tier which is nominally the "max" can appear once before the end of the array, then again at the end to trigger the end of the tier looping. For the PR, this is so that UMV glass can be at the index of UMV tier, but also at the very end of the glass array (after all the variant glasses) so that full stack projector usage still uses it.