Fix some multiblock placements aborting too early #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#18510
This problem arises when the multiple
survivialBuildPiece()
are+=
insurvivalConstruct()
since returning anything below 0 would previously cause the preview construction to abort.A possible example for the YottTank with some edits to illustrate the point
Previously we fixed that by adding
if (built > 0) return built;
after mostsurvivialBuildPiece()
but that's kinda annoying and unnecessary, especially since we can check whether something was actually placed in the world to more reliably determine whether construction should stop.