Show previews for multiblocks that contain searched item #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyfts
force-pushed
the
show-multi-from-casing
branch
from
96c8ec9 to
d843927
Compare
Ethryan
approved these changes
Nov 24, 2024
OneEyeMaker
approved these changes
Nov 24, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently very restricted in which blocks it looks for, but it should still cover the majority of the blocks used in multis. If any major ones are missing just lmk
There's also a few micro-optimizations sprinkled in via gtnhlib & fastutil to kill off some dumb allocations.
The preview will now also start at the tier that contains the searched block
A gui refactor was added free of charge because it was a massive headache to work with before and kept breaking in stupid ways. Everything looks and works exactly as it used to, but is now 50% less likely to induce throbbing headaches.Nah nevermind, I'll be making a different pr that reworks the gui to be more user friendly
Closes GTNewHorizons/GT-New-Horizons-Modpack#17775
Also fixes a crash when right clicking some blocks in the railcraft boiler previews. It's such a small fix which I don't feel necessitates a separate pr, plus one of the classes have been renamed in this pr which makes porting it annoying.
Closes GTNewHorizons/GT-New-Horizons-Modpack#16421