Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multipart/form-data for rocket form submit #80

Merged
merged 1 commit into from
May 29, 2023

Conversation

BouncyLlama
Copy link
Contributor

changing the octet-stream here to multipart/form-data. Rocket seems to return a 404 because it doesn't expect octet-stream on a form post. Using multipart also enables a better experience w/ the swagger and rapidoc tooling where you can have a mixture of fields and files be supported there in the UI rather than an opaque blob for the request body. Should go along with GREsau/schemars#135

@ralpha ralpha merged commit 0218870 into GREsau:master May 29, 2023
@ralpha
Copy link
Collaborator

ralpha commented May 29, 2023

Looks good. This indeed looks better.
Did not had to time to test it, but I hope I can trust you in that it will work as intended. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants