Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of which in configure #3

Open
vnmabus opened this issue Feb 13, 2025 · 2 comments · May be fixed by #4
Open

Remove usage of which in configure #3

vnmabus opened this issue Feb 13, 2025 · 2 comments · May be fixed by #4

Comments

@vnmabus
Copy link

vnmabus commented Feb 13, 2025

When trying to install the aspell-en dictionary inside a Docker container, I had an error in the configure script because it tries to use the which command, which is not present in Docker by default. My proposal is to change this usage and use the command -v incantation instead, in a manner similar to what Apache did here.

Please @kevina forgive me if this is not the correct place for such a suggestion. I tried to pinpoint the origin of that configure script and the official webpage seemed to indicate that this is the tool used for packaging the dictionaries, and thus the origin of that configure script. However it seems like this tool has not be touched for years, so maybe the current packaging is done differently. In that case I would be glad if you could point me to the right place.
@kevina
Copy link
Member

kevina commented Feb 14, 2025 •
edited
Loading

This is the correct place to fix the script. However the dictionaries will also need to be updated to use the newer script so an issue should also be filed at https://github.com/en-wl/wordlist/issues.

The dictionary has not been updated in a while, but there should be some sort of release this year.

vnmabus added a commit to vnmabus/aspell-lang that referenced this issue Feb 17, 2025
@vnmabus
configure: replace which command with command -v
45c28a5 
The command `which` is not present in some
contexts, such as docker.
It is better to just use `command -v`, which is
builtin into the shell.

Fixes GNUAspell#3
@vnmabus vnmabus linked a pull request Feb 17, 2025 that will close this issue
Open
@vnmabus
Copy link
Author

vnmabus commented Feb 21, 2025

I added a PR to fix it in #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: replace which command with command -v vnmabus/aspell-lang
2 participants
@kevina @vnmabus