Some sonar-lint bugs/security hotspots #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtroilo
changed the title
joker234
reviewed
Aug 12, 2021
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/db/OSHDBH2.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/db/OSHDBH2.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/db/OSHDBJdbc.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/tagtranslator/TagTranslator.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/main/java/org/heigit/ohsome/oshdb/util/time/TimestampFormatter.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/mapreducer/backend/MapReducerJdbc.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/mapreducer/backend/MapReducerJdbc.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/mapreducer/backend/MapReducerJdbc.java
Outdated
Show resolved
Hide resolved
oshdb-etl/src/main/java/org/heigit/ohsome/oshdb/tool/importer/extract/Extract.java
Show resolved
Hide resolved
oshdb-etl/src/main/java/org/heigit/ohsome/oshdb/tool/importer/extract/Extract.java
Show resolved
Hide resolved
rtroilo
force-pushed
the
fix_some_sonarlint_issues
branch
2 times, most recently
from
6d470c0 to
3a7b421
Compare
rtroilo
force-pushed
the
fix_some_sonarlint_issues
branch
from
3a7b421 to
fe5a50f
Compare
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
rtroilo
force-pushed
the
fix_some_sonarlint_issues
branch
from
fe5a50f to
3619224
Compare
tyrasd
reviewed
Aug 13, 2021
Co-authored-by: Martin Raifer <martin.raifer@heigit.org>
tyrasd
reviewed
Aug 13, 2021
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/db/OSHDBJdbc.java
Outdated
Show resolved
Hide resolved
tyrasd
reviewed
Aug 13, 2021
oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/mapreducer/backend/MapReducerJdbc.java
Outdated
Show resolved
Hide resolved
joker234
reviewed
Aug 13, 2021
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
joker234
added
the
breaking
tyrasd
added a commit
that referenced
this pull request
Aug 13, 2021
* cells are fetched individually instead of in a single sql query * properly closes database resources see #419 (comment) for more background This reverts commit 69f958b.
tyrasd
force-pushed
the
fix_some_sonarlint_issues
branch
2 times, most recently
from
a88a9fb to
a6365a7
Compare
rtroilo
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should, hopefully, fix the remaining bugs and security hotspots of sonar-lint
Checklist
I have commented my codeI have written javadoc (required for public classes and methods)I have added sufficient unit testsI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository