-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MAPL dependencies for MAPL-as-library in CMake #2320
Conversation
… is merged and finds its way into the ufs-weather-model dependency tree
I have tested this with GEOS and it of course works since we don't do |
…/MAPL#2320 is merged and finds its way into the ufs-weather-model dependency tree
@mathomp4 Just wanted to let you know that I am doing the spack-stack 1.5.0 release/installs this week and last week, therefore no time to test, sorry. |
@climbfuji Well, at this point it can't be worse than what we have now. I figure get it in and if it works, huzzah! If not, well, new data point! 😄 |
Fine with me! |
… is merged and finds its way into the ufs-weather-model dependency tree
…/MAPL#2320 is merged and finds its way into the ufs-weather-model dependency tree
Description
This is an attempt to fix an issue being seen by @climbfuji in using the latest MAPL in UFS. I believe the problem is that now MAPL is being built with pFlogger (and fArgparse?) support and GOCART-as-UFS builds doesn't know that those are needed.
I tried to do some limited testing locally and I think this solves at least the CMake problems. The main thing is I can't do any building because I don't think I have the right flags set (since I'm building as
-DUFS_GOCART=ON
) and so I get:Related Issue
Motivation and Context
Let's users of MAPL-as-library via
find_package(MAPL)
get dependencies correct.How Has This Been Tested?
Not much at all.
Types of changes
Checklist: