Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ARGO no file bomb, and obs file age checks #22

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

vrx-
Copy link
Contributor

@vrx- vrx- commented Mar 5, 2025

Problem:
@lren20 identified that some ODAS cycles ran without Argo data in 2024. The issue was caused by DBOSS updating observation files in a morning window for the current and past years. This caused spurious inconsistencies in the number of observations between the 1st and 2nd passes of the ODAS.

This PR:

  • Adds a function in oncean_obs.py to crash the model from the ODAS if a required observation file is not located. This function is applied in the argo reader, for both ARGO_T and ARGO_S
  • Adds a function to wait on a predetermined file age (5 minutes), so that the observer will wait while the file is younger than age.
  • Updates minimum observation requirements to T and S profiles, and ADT observations.

Tests:

  • Ran model with 2025/01/01 initialization, and obtained expected behavior.
  • @lren20 tested zero diffs in temp and salt increments with a past run. Also performed tests on expected behavior for when an argo file was not present or was too young.

@vrx- vrx- added Skip Changelog Skips the Changelog Enforcerx 0 diff The changes in this pull request have been verified to be zero-diff with the target branch. labels Mar 5, 2025
@vrx- vrx- requested a review from a team as a code owner March 5, 2025 20:20
Copy link
Collaborator

@amolod amolod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming that the tests were run on SLES15 Cascade Lake as well as Milan nodes.

@amolod amolod merged commit 3f5b1a1 into main Mar 5, 2025
3 checks passed
@amolod amolod deleted the feature/vruizxom/odas_req_check branch March 5, 2025 20:23
@lren20
Copy link

lren20 commented Mar 5, 2025

My test was run on SLES15 Cascade Lake.

@vrx-
Copy link
Contributor Author

vrx- commented Mar 5, 2025

I ran in Milan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have been verified to be zero-diff with the target branch. Skip Changelog Skips the Changelog Enforcerx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants