fix: Remove shadow declarations #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
requested review from
rrsettgast,
wrtobin,
untereiner and
CusiniM
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3293 +/- ##
========================================
Coverage 56.32% 56.32%
========================================
Files 1065 1065
Lines 90210 90210
========================================
Hits 50807 50807
Misses 39403 39403 ☔ View full report in Codecov by Sentry. |
paveltomin
approved these changes
Sep 6, 2024
rrsettgast
approved these changes
Sep 7, 2024
rrsettgast
approved these changes
Sep 18, 2024
|
one of the CI jobs should have |
CusiniM
approved these changes
Sep 19, 2024
rrsettgast
added
the
ci: run integrated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build with clang-17.0.4 issues errors of the form
This PR fixes this.