Fix for black oil #2937
Merged
Fix for black oil #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
approved these changes
Jan 16, 2024
| phaseCompFraction.value[ipOil][icOil] = zo; | ||
| phaseCompFraction.value[ipOil][icGas] = zg; | ||
| phaseCompFraction.value[ipOil][icOil] = zo / ( zo + zg ); | ||
| phaseCompFraction.value[ipOil][icGas] = zg / ( zo + zg ); |
There was a problem hiding this comment.
I would have written this as for example zo / (1 - zw) which should have no impact here but would have an impact on the derivatives. Have you looked at the Jacobian in this alternative formulation. I find these composition derivatives a bit confusing when honouring that they sum to 1.
There was a problem hiding this comment.
just checked - Jacobian is the same, number of linear iterations is the same, I will update with your version
paveltomin
added
ci: run integrated tests
paveltomin
added
ci: run CUDA builds
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2937 +/- ##
========================================
Coverage 51.33% 51.33%
========================================
Files 968 968
Lines 86817 86819 +2
========================================
+ Hits 44570 44572 +2
Misses 42247 42247 ☔ View full report in Codecov by Sentry. |
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* fix for black oil --------- Co-authored-by: Pavel Tomin <“paveltomin@users.noreply.github.com”> Co-authored-by: Matteo Cusini <49037133+CusiniM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix small bug in black oil computations
One test case requires rebaseline, rebase PR here https://github.com/GEOS-DEV/integratedTests/pull/84