Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the naming of the fluid heat capacity #2924

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

frankfeifan
Copy link
Contributor

@frankfeifan frankfeifan commented Jan 5, 2024

This PR changes the naming of heat capacity in the fluid model as previous volumetricHeatCapacity is misleading. We are actually using the heat capacity for a specific fluid mass (unit: J/K/kg).

This PR is also related to the issue #2923

integratedTests PR: https://github.com/GEOS-DEV/integratedTests/pull/81

@frankfeifan frankfeifan self-assigned this Jan 5, 2024
@jhuang2601
Copy link
Contributor

What is the correct unit and name of the Heat Capacity in SolidInternalEnergy?

@frankfeifan
Copy link
Contributor Author

frankfeifan commented Jan 5, 2024

What is the correct unit and name of the Heat Capacity in SolidInternalEnergy?

For SolidInternalEnergy, the unit of heat capacity should be J/K/m^3 according to the calculation here. So the name is correct for the solid model.

@jhuang2601
Copy link
Contributor

What is the correct unit and name of the Heat Capacity in SolidInternalEnergy?

For SolidInternalEnergy, the unit of heat capacity should be J/K/m^3 according to the calculation here. So the name is correct for the solid model.

Thanks @frankfeifan for this clarification. For the existing tutorial example, heat capacity for solid should be 1.672e5 J/K/m^3, which was provided by reference work.

@jhuang2601 jhuang2601 linked an issue Jan 5, 2024 that may be closed by this pull request
@jhuang2601 jhuang2601 added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 5, 2024
@frankfeifan
Copy link
Contributor Author

frankfeifan commented Jan 5, 2024

What is the correct unit and name of the Heat Capacity in SolidInternalEnergy?

For SolidInternalEnergy, the unit of heat capacity should be J/K/m^3 according to the calculation here. So the name is correct for the solid model.

Thanks @frankfeifan for this clarification. For the existing tutorial example, heat capacity for solid should be 1.672e5 J/K/m^3, which was provided by reference work.

Yes. I think the values of heat capacity for both fluid and solid in this tutorial should be reasonable, maybe a bit smaller than their real values from experiment, e.g., the heat capacity of water is around 4e3 J/K/kg. But I think it should be fine just for model verification.

The issue here is that the current name of fluid heat capacity is misleading, and its unit is actually different from that of the solid (J/K/kg v.s. J/K/m^3). That's why the heat capacity values for the solid and fluid are very different in the tutorial example.

@sytuannguyen
Copy link
Contributor

@frankfeifan I would propose to consider Specific Heat Capacity in place of Heat Capacity.

@frankfeifan
Copy link
Contributor Author

@frankfeifan I would propose to consider Specific Heat Capacity in place of Heat Capacity.

Yes. specificHeatCapacity is a better option. I have updated the code accordingly.

@jhuang2601 jhuang2601 added flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 9, 2024
@CusiniM CusiniM merged commit a6a01de into develop Jan 17, 2024
@CusiniM CusiniM deleted the bugfix/fei/fixFluidHeatCapacityName branch January 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volumetric Heat Capacity Values are Off for THM Examples
5 participants