-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the naming of the fluid heat capacity #2924
Conversation
What is the correct unit and name of the Heat Capacity in |
For |
Thanks @frankfeifan for this clarification. For the existing tutorial example, heat capacity for solid should be 1.672e5 J/K/m^3, which was provided by reference work. |
Yes. I think the values of heat capacity for both fluid and solid in this tutorial should be reasonable, maybe a bit smaller than their real values from experiment, e.g., the heat capacity of water is around 4e3 J/K/kg. But I think it should be fine just for model verification. The issue here is that the current name of fluid heat capacity is misleading, and its unit is actually different from that of the solid (J/K/kg v.s. J/K/m^3). That's why the heat capacity values for the solid and fluid are very different in the tutorial example. |
@frankfeifan I would propose to consider Specific Heat Capacity in place of Heat Capacity. |
Yes. |
This PR changes the naming of heat capacity in the fluid model as previous
volumetricHeatCapacity
is misleading. We are actually using the heat capacity for a specific fluid mass (unit: J/K/kg).This PR is also related to the issue #2923
integratedTests PR: https://github.com/GEOS-DEV/integratedTests/pull/81