Migrate python packages #2896
Migrate python packages #2896
Conversation
cssherman
added
type: cleanup / refactor
|
@rrsettgast - for this change to work smoothly, we'll also want to move the python tool documentation to the new repo. I've done so here: GEOS-DEV/geosPythonPackages#1 . We should be able to treat this repo as a subproject in readthedocs (see https://docs.readthedocs.io/en/stable/subprojects.html). Any thoughts/concerns? |
|
Here are the new separate docs for the python tools: https://geosx-geospythonpackages.readthedocs-hosted.com/en/latest/ |
|
@cssherman Could this new repo have its own CI for the docs instead of fetching it in this repository ? |
Yes, that's what I'm working towards. The RTD platform allows sub-projects, with different release schedules per repo |
| TMP_CLONE_DIR=$(mktemp -d) | ||
| PACKAGE_DIR=$TMP_CLONE_DIR/geosPythonPackages | ||
| git clone --depth 1 --branch main --single-branch https://github.com/GEOS-DEV/geosPythonPackages.git $PACKAGE_DIR | ||
| elif [ ! -d "${PACKAGE_DIR}/geosx_xml_tools_package" ] |
There was a problem hiding this comment.
This is just a quick check to see if the directory is close to correct. There are later error messages that will be printed if other packages are broken/missing.
cssherman
force-pushed
the
feature/sherman/migratePythonPackages
branch
from
b9249a1 to
f6e9892
Compare
cssherman
added
ci: run integrated tests
| if $VERBOSE | ||
| INSTALL_MSG=$($PYTHON_TARGET -m $PIP_CMD install $p) | ||
| INSTALL_MSG=$($PYTHON_TARGET -m $PIP_CMD install $PACKAGE_DIR/$p) |
There was a problem hiding this comment.
Is it possible to install directly from the url (like python -m pip install https://github.com/GEOS-DEV/geosPythonPackages.git/...)?
That would prevent us from removing by hand the temporary which is always a scary part.
| ) | ||
|
|
||
| else() | ||
| message(WARNING "Building the GEOSX python tools requires Python >= 3.6.") |
There was a problem hiding this comment.
| message(WARNING "Building the GEOSX python tools requires Python >= 3.6.") | |
| message(WARNING "Building the GEOSX python tools requires Python >= 3.6. No version was provided.") |
There was a problem hiding this comment.
| message(WARNING "Building the GEOSX python tools requires Python >= 3.6.") | |
| message(WARNING "Building the GEOS python tools requires Python >= 3.6. No version was provided.") |
cssherman
force-pushed
the
feature/sherman/migratePythonPackages
branch
from
f6e9892 to
1e71457
Compare
|
why does this require baselines ? |
| WORKING_DIRECTORY ${CMAKE_BINARY_DIR} | ||
| ) | ||
|
|
||
| add_custom_target( geosx_python_tools |
There was a problem hiding this comment.
shouldn't we call these geos_python_tools at some point?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2896 +/- ##
========================================
Coverage 51.42% 51.42%
========================================
Files 966 966
Lines 86672 86672
========================================
Hits 44571 44571
Misses 42101 42101 ☔ View full report in Codecov by Sentry. |
* Migrating python packages to a new repo
This PR removes old copies of the python packages that have been moved to their own repository: https://github.com/GEOS-DEV/geosPythonPackages . The
setupPythonEnvironment.bashscript will now fetch the latest version of these packages from the internet.integratedTests PR: https://github.com/GEOS-DEV/integratedTests/pull/77