Use GHA's if: instead of dedicated jobs
#2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotoGaz
added
ci: run integrated tests
bmhan12
approved these changes
Dec 6, 2023
jhuang2601
approved these changes
Dec 6, 2023
rrsettgast
approved these changes
Dec 6, 2023
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
This prevents from having specific jobs acting as gates to label-driven jobs. Those jobs (e.g. are_integrated_tests_requested) may appear KO and the whole workflow would come red because an optional job was not triggered. Using GHA's native if: pattern in the yaml keeps the workflow green when the integrated tests are not triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents from having specific jobs acting as gates to
label-driven jobs.Those jobs (e.g.
are_integrated_tests_requested) may appearKOand the whole workflow would come red because an optional job was not triggered.Using GHA's native
if:pattern in theyamlkeeps the workflow green when the integrated tests are not triggered.@jhuang2601