Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #2837 and #2838 #2843

Merged
merged 16 commits into from
Dec 13, 2023
Merged

Fix issues #2837 and #2838 #2843

merged 16 commits into from
Dec 13, 2023

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Nov 22, 2023

Fix failing case (compositionalMultiphaseFlow/deadoil_3ph_corey_1d_fractured.xml) and correct PVT table.
The case is not in the integratedTests, but may require rebaseline since the table is being used by other cases which are in the integratedTests.
Also fix convergence problem for multiphaseFlowFractures/deadoil_3ph_corey_2d_impermeableFault.xml by disabling line search.

rebaseline in https://github.com/GEOS-DEV/integratedTests/pull/69

@paveltomin paveltomin added type: testing Unit tests, non-regression testing, ... flag: ready for review labels Nov 22, 2023
@paveltomin paveltomin requested a review from CusiniM November 22, 2023 16:24
@paveltomin paveltomin self-assigned this Nov 22, 2023
@paveltomin paveltomin changed the title Fix issue #2837 Fix issues #2837 and #2838 Nov 22, 2023
@jhuang2601 jhuang2601 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 1, 2023
@paveltomin paveltomin removed the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 6, 2023
@paveltomin paveltomin added flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 7, 2023
@jhuang2601
Copy link
Contributor

This PR went through ci: run integrated tests and requires rebaseline.

ATS END OF RUN STARTED December 08, 2023 19:10:01
    Status     : TestCase                                          : Directory                                                                 : Elapsed : Resources : TestStep  
    ---------- : ------------------------------------------------- : ------------------------------------------------------------------------- : ------- : --------- : ----------
    FAIL CHECK : deadoil_3ph_staircase_hybrid_3d_01                : compositionalMultiphaseFlow/deadoil_3ph_staircase_hybrid_3d_01            : 0:00:34 : 0:00:34   : restartcheck
    FAIL CHECK : deadOil_fractureMatrixFlow_edfm_inclinedFrac_01   : multiphaseFlowFractures/deadOil_fractureMatrixFlow_edfm_inclinedFrac_01   : 0:00:57 : 0:00:57   : restartcheck
    FAIL CHECK : deadOil_fractureMatrixFlow_edfm_horizontalFrac_01 : multiphaseFlowFractures/deadOil_fractureMatrixFlow_edfm_horizontalFrac_01 : 0:00:23 : 0:00:23   : restartcheck
    FAIL CHECK : deadOil_fractureMatrixFlow_edfm_horizontalFrac_02 : multiphaseFlowFractures/deadOil_fractureMatrixFlow_edfm_horizontalFrac_02 : 0:00:13 : 0:00:27   : restartcheck
    FAIL CHECK : deadoil_3ph_baker_1d_01                           : compositionalMultiphaseFlow/deadoil_3ph_baker_1d_01                       : 0:00:08 : 0:00:08   : restartcheck
    FAIL CHECK : deadoil_3ph_corey_1d_02                           : compositionalMultiphaseFlow/deadoil_3ph_corey_1d_02                       : 0:00:05 : 0:00:11   : restartcheck
    FAIL CHECK : PoroElastic_permeableFault_smoke_01               : poroElasticCoupling/PoroElastic_permeableFault_smoke_01                   : 0:00:04 : 0:00:04   : restartcheck
    FAIL CHECK : deadoil_3ph_corey_1d_01                           : compositionalMultiphaseFlow/deadoil_3ph_corey_1d_01                       : 0:00:08 : 0:00:08   : restartcheck
    FAIL CHECK : PoroElastic_impermeableFault_smoke_01             : poroElasticCoupling/PoroElastic_impermeableFault_smoke_01                 : 0:00:05 : 0:00:05   : restartcheck
    FAIL CHECK : deadoil_3ph_baker_1d_02                           : compositionalMultiphaseFlow/deadoil_3ph_baker_1d_02                       : 0:00:06 : 0:00:12   : restartcheck
    ---------- : ------------------------------------------------- : ------------------------------------------------------------------------- : ------- : --------- : ----------

@TotoGaz TotoGaz removed the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 9, 2023
@TotoGaz TotoGaz added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 12, 2023
@TotoGaz TotoGaz merged commit 5e1c3b6 into develop Dec 13, 2023
@TotoGaz TotoGaz deleted the pt/fix-issue-2837 branch December 13, 2023 01:35
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
- Fix failing case (`compositionalMultiphaseFlow/deadoil_3ph_corey_1d_fractured.xml`) and correct PVT table.
- Fix convergence problem for `multiphaseFlowFractures/deadoil_3ph_corey_2d_impermeableFault.xml` by disabling line search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: testing Unit tests, non-regression testing, ...
Projects
None yet
3 participants