Enhance the fracture generation feature of mesh_doctor
#2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking duplicated nodes for fractures and matrix.
5 tasks
TotoGaz
commented
Nov 30, 2023
There was a problem hiding this comment.
Note that this is a complete rewriting of the algorithm; therefore it's not particularly relevant to compare the two files during the code review process.
cssherman
reviewed
Nov 30, 2023
| collocated_nodes: numpy.ndarray = vtk_to_numpy(fracture_mesh.GetPointData().GetArray("collocated_nodes")) | ||
| if len(collocated_nodes.shape) == 1: | ||
| collocated_nodes: numpy.ndarray = collocated_nodes.reshape((collocated_nodes.shape[0], 1)) | ||
| return tuple(map(lambda bucket: tuple(sorted(filter(lambda i: i != -1, bucket))), collocated_nodes)) |
There was a problem hiding this comment.
This is completely fine (and maybe a bit faster?), but I find list comprehension+slicing to be much more readable/pythonic than lambdas+maps+filters:
tuple([tuple(sorted(bucket[bucket != -1])) for bucket in collected_nodes])
There was a problem hiding this comment.
You are right, it's far better!
TotoGaz
added
ci: run CUDA builds
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
- Complete rewriting of the fracture generation algorithm. There should be not limitation anymore, and it supports `VTK_POLYHEDRON` thanks to @IsaacJu-debug 's investigations. - Efforts were paid to validate the code using `mypy` and type hints. Not perfect yet, but still a good improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTK_POLYHEDRONthanks to @IsaacJu-debug 's investigations.mypyand type hints. Not perfect yet, but still a good improvement.