Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a single quadrature point for FaceElements #2784

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

CusiniM
Copy link
Collaborator

@CusiniM CusiniM commented Oct 26, 2023

Currently, there is no need to create a FE for FaceElementsSubRegions since we don't do any FE calculation on them.

In the future, we may want to define 2D spaces for them but it's not easy since they can heterogeneous.

In any case, this PR allows to run solidMechanics simulations on external meshes with conforming fractures.

Rebaseline https://github.com/GEOS-DEV/integratedTests/pull/78

@CusiniM CusiniM self-assigned this Oct 26, 2023
@CusiniM CusiniM added the EPIC - FF/Import Import of external faults and fractures label Oct 26, 2023
@CusiniM CusiniM requested review from TotoGaz and rrsettgast October 26, 2023 19:17
Co-authored-by: TotoGaz <49004943+TotoGaz@users.noreply.github.com>
@TotoGaz TotoGaz marked this pull request as ready for review December 13, 2023 17:39
@TotoGaz TotoGaz added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 13, 2023
@TotoGaz TotoGaz removed the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 13, 2023
@TotoGaz TotoGaz added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Dec 14, 2023
@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 16, 2023
@TotoGaz TotoGaz merged commit 4c52463 into develop Dec 21, 2023
@TotoGaz TotoGaz deleted the cusini/bugFix/defineQuadPointsOnFaceElements branch December 21, 2023 01:56
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
Currently, there is no need to create a FE for FaceElementsSubRegions since we don't do any FE calculation on them.
In the future, we may want to define 2D spaces for them but it's not easy since they can heterogeneous.
In any case, this PR allows to run solidMechanics simulations on external meshes with conforming fractures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI EPIC - FF/Import Import of external faults and fractures flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants