A few solver messages rework #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a few getDataContext() references where it was forgotten - removed some `` (it will be added later on DataContext::toString())
MelReyCG
added
type: cleanup / refactor
MelReyCG
changed the title
paveltomin
reviewed
Oct 26, 2023
| @@ -53,6 +53,11 @@ class SolverBase : public ExecutableGroup | |||
|
|
|||
| static string catalogName() { return "SolverBase"; } | |||
There was a problem hiding this comment.
@rrsettgast should we remove all those base catalogNames?
There was a problem hiding this comment.
yes...but we can do that in its own PR. We can also do some of what we talked about yesterday.
paveltomin
reviewed
Oct 26, 2023
| /** | ||
| * @copydoc SolverBase::getCatalogName() | ||
| */ | ||
| string getCatalogName() const override { return catalogName(); } |
There was a problem hiding this comment.
would it be possible to avoid redefining that function for every solver?
There was a problem hiding this comment.
No. It is a virtual function, so it will give the right name when you ask for the name through a base pointer....unless there is a way to have a derived class override a virtual function without defining the override.
paveltomin
reviewed
Oct 26, 2023
paveltomin
approved these changes
Oct 26, 2023
dkachuma
approved these changes
Oct 31, 2023
src/coreComponents/physicsSolvers/solidMechanics/SolidMechanicsLagrangianFEM.cpp
Outdated
Show resolved
Hide resolved
…gful-solver-class-name
…duce under the hood
…gful-solver-class-name
|
@MelReyCG please resolve conflicting files |
paveltomin
reviewed
Nov 30, 2023
src/coreComponents/physicsSolvers/multiphysics/CompositionalMultiphaseReservoirAndWells.cpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 30, 2023
src/coreComponents/physicsSolvers/multiphysics/MultiphasePoromechanics.cpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 30, 2023
src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanics.cpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 30, 2023
src/coreComponents/physicsSolvers/multiphysics/SinglePhaseReservoirAndWells.cpp
Show resolved
Hide resolved
|
I took the last comments into account, is it good to go ? |
As long as the file conflict is resolved :) |
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* aquifer production logging rewrite with unit fix * expose the final class name with getCatalogName() * Used final class where possible on solvers + - added a few getDataContext() references where it was forgotten - removed some `` (it will be added later on DataContext::toString()) * uncrustify * reformulation * removed some direct fmt references * Changed reduce() functions to Allreduce() where it is in fact a AllReduce under the hood * added MpiWrapper::reduce (to avoid unneeded Allreduce()) * replaced a message by a warning (because it is effectively) * replaced flux term by volume * compil fixes * Output names rather than data contexts at some places --------- Co-authored-by: Pavel Tomin <paveltomin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to rework some messages by:
using meaningful class names in log lines & errors instead of abstract class names (using the final class catalog name, as it is done in other places).
fixing the unit in use in the following log line:
FlowSolverBase compositionalMultiphaseFlow (aquifer.xml, l.28): at time 100s, the <Aquifer> boundary condition 'aquifer1' produces a flux of -0.6181975187076816 kg (or moles if useMass=0).Our investigations showed that the output value is in
m³.The proposed new formulation is:
Aquifer aquifer1 (aquifer.xml, l.226): at time 100s, the boundary condition produces a flux of -0.6181975187076816 m3.remove some direct
fmt::formatreference in favor ofGEOS_FMT.