MGR strategies cleanup #2409
Merged
MGR strategies cleanup #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castelletto1
added
type: cleanup / refactor
victorapm
reviewed
Apr 26, 2023
victorapm
reviewed
Apr 26, 2023
src/coreComponents/linearAlgebra/interfaces/hypre/mgrStrategies/CompositionalMultiphaseFVM.hpp
Outdated
Show resolved
Hide resolved
victorapm
reviewed
Apr 26, 2023
...ponents/linearAlgebra/interfaces/hypre/mgrStrategies/CompositionalMultiphaseReservoirFVM.hpp
Outdated
Show resolved
Hide resolved
victorapm
reviewed
Apr 26, 2023
...ponents/linearAlgebra/interfaces/hypre/mgrStrategies/CompositionalMultiphaseReservoirFVM.hpp
Outdated
Show resolved
Hide resolved
francoishamon
approved these changes
Apr 27, 2023
src/coreComponents/linearAlgebra/interfaces/hypre/HypreUtils.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/linearAlgebra/interfaces/hypre/mgrStrategies/SinglePhaseReservoirFVM.hpp
Outdated
Show resolved
Hide resolved
victorapm
approved these changes
Apr 28, 2023
|
This PR is ready for a last round of review. Testing in progress for problems provided by @francoishamon. |
|
Looks great to me. Thanks again! |
klevzoff
approved these changes
Oct 3, 2023
castelletto1
added
ci: run CUDA builds
|
anything in this PR that will affect runs with MGR? |
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Cleaning MGR strategies * Replacing FRelaxMethod with FRelaxType * Allowing Gaussian elimination for wells (temporarily) only on CPU * Unique jacobi for CPU and GPU in MGR strategies * Removing calls to HYPRE_MGRSetTruncateCoarseGridThreshold in MGR strategies --------- Co-authored-by: Randolph Settgast <settgast1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a method
setReductionin classMGRStrategyBasethat is used in thesetupmethod in each strategy. For levellof each strategy the following details are specified:Note that the F-relaxation type is now set instead of the method (see comment in hypre here). Also, methods have been added in class
MGRStrategyBaseto configure boomerAMG for mechanics, pressure and pressure/temperature systems.Additional features that will be included as hypre allows for it:
HYPRE_MGRSetPMaxElmts)