Add LaplaceBase class #1385
Merged
Add LaplaceBase class #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement constructor and use it in LaplaceFEM and LaplaceVEM. Update catalog.
Moved code from LaplaceVEM:implicitStepSetup(). This is done for symmetry with LaplaceFEM.
Copied code has been commented out and will be removed in a following commit. Sphinx documentation to be checked and fixed.
andrea-borio
requested review from
francoishamon,
castelletto1,
joshua-white and
rrsettgast
rrsettgast
approved these changes
Apr 23, 2021
src/docs/sphinx/developerGuide/KeyComponents/AddingNewSolver.rst
Outdated
Show resolved
Hide resolved
francoishamon
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Thanks @andrea-borio for the refactoring. I only added minor comments.
| struct viewKeyStruct : public SolverBase::viewKeyStruct | ||
| { | ||
| dataRepository::ViewKey timeIntegrationOption = { "timeIntegrationOption" }; | ||
| dataRepository::ViewKey fieldVarName = { "fieldName" }; |
There was a problem hiding this comment.
Here we could use the new way
Suggested change
| dataRepository::ViewKey fieldVarName = { "fieldName" }; | |
| static constexpr char const * fieldVarName() { return "fieldName"; } |
to be consistent with the other solvers.
src/docs/sphinx/developerGuide/KeyComponents/AddingNewSolver.rst
Outdated
Show resolved
Hide resolved
src/docs/sphinx/developerGuide/KeyComponents/AddingNewSolver.rst
Outdated
Show resolved
Hide resolved
src/docs/sphinx/developerGuide/KeyComponents/AddingNewSolver.rst
Outdated
Show resolved
Hide resolved
castelletto1
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the objective of creating a common base class for Laplace solvers that are based on FEM and VEM.