Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debug-build compile fail on Lassen #1337

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

wrtobin
Copy link
Collaborator

@wrtobin wrtobin commented Feb 25, 2021

This only effects the Debug build on Lassen. The Release and RelWithDebInfo builds work fine, which is why the nightlies didn't fail. Only one travis might have caught this: Ubuntu18.04_clang8.0.0_cuda10.1.243_debug, but presumably compiler/other version differences prevented it?

There was a host-only call ( serialReduce::get() ) inside a host-device lambda.

Copy link
Contributor

@corbett5 corbett5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, I thought I compiled just a day or two ago. Nice catch!

…phaseHybridFVMKernels.hpp

Co-authored-by: Ben Corbett <32752943+corbett5@users.noreply.github.com>
@corbett5 corbett5 merged commit c2d2721 into develop Feb 25, 2021
@corbett5 corbett5 deleted the bugfix/wrtobin/serial-reduce-from-host-device branch February 25, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants