Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low order acoustic wave equation #1269

Merged
merged 80 commits into from
Mar 30, 2021
Merged

Conversation

mndiaye24
Copy link
Contributor

@mndiaye24 mndiaye24 commented Jan 13, 2021

First order Spectral Element Method (SEM) for the second order acoustic wave equation.

In this PR we propose the first version of the acoustic wave solver using the SEM.

The space discretization is performed using the finite element implementation provide in GEOSX. For the time integration, we use first order central finite difference scheme.

We propose an implementation with a first order Absorbing Boundary Condition (ABC).
We can also specify a free surface using the geometry boxes and field specification in the xml file.

The source injected is assumed to be a Dirac at one point inside the computational domain. It coordinate must be specified in the xml file and should be located inside one of the mesh element. It is possible to specify more than one coordinate, each coordinate will be treated as an independent source point.
Once the sources coordinate are specified, it is mandatory to specify the central time frequency for the evaluation of a Ricker function.

As for the source, the receivers locations must be specified in xml file as well.

Related to https://github.com/GEOSX/integratedTests/pull/128

sem_for_time_acoustic_equation.pdf

@rrsettgast rrsettgast changed the title Feature/low order wave eqn Low order acoustic wave equation Jan 13, 2021
@mndiaye24
Copy link
Contributor Author

Thanks @corbett5 for your review. I made some change to take into account most of your suggestion.
Now @labesse40 has merge his work on pygeosx use case in this branch. All the file he used are in the folder src/coreComponents/physicsSolvers/wavePropagation/pygeosx. Since he needed to set a current time to zero for each new shot, we have added a new condition a the beginning of explicitStep in order to update precomputed variable for the new shot.

Copy link
Contributor

@corbett5 corbett5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be committing pyc files to the repo. If its not already in the .gitignore can you add it?

Copy link
Contributor

@corbett5 corbett5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to be adding the .sgy files to the repo?

Copy link
Member

@rrsettgast rrsettgast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the suggestions I was going to provide would be better saved for a follow on PR. Just get the integrated test baseline in and merge.

CellElementSubRegion & elementSubRegion )
{

arrayView2d< localIndex const, cells::NODE_MAP_USD > const & elemsToNodes = elementSubRegion.nodeList();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corbett5 I think it will be necessary very shortly, so we can just leave it in.

@mndiaye24
Copy link
Contributor Author

mndiaye24 commented Mar 23, 2021

Do we want to be adding the .sgy files to the repo?

The .sgy are removed now.

@mndiaye24 mndiaye24 closed this Mar 23, 2021
@mndiaye24 mndiaye24 reopened this Mar 23, 2021
@mndiaye24
Copy link
Contributor Author

Hello everyone, @rrsettgast @corbett5 @francoishamon
@labesse40 has modified the python code to take into account Ben suggestion. At this stage, we decided to remove the pyhton part fron this PR. We will define a new PR only for the python and pygeox work when this first version of the acoustic solver is merged into develop. Thank you all for your review.

@francoishamon francoishamon merged commit 6cdb6a1 into develop Mar 30, 2021
@francoishamon francoishamon deleted the feature/lowOrderWaveEqn branch March 30, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants