-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low order acoustic wave equation #1269
Conversation
Thanks @corbett5 for your review. I made some change to take into account most of your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be committing pyc
files to the repo. If its not already in the .gitignore
can you add it?
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/functions.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/functions.py
Outdated
Show resolved
Hide resolved
…iew. remove callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to be adding the .sgy
files to the repo?
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/functions.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/main.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/mesh.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/mesh.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/mesh.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/receiver.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/receiver.py
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/wavePropagation/pygeosx/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the suggestions I was going to provide would be better saved for a follow on PR. Just get the integrated test baseline in and merge.
CellElementSubRegion & elementSubRegion ) | ||
{ | ||
|
||
arrayView2d< localIndex const, cells::NODE_MAP_USD > const & elemsToNodes = elementSubRegion.nodeList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corbett5 I think it will be necessary very shortly, so we can just leave it in.
src/coreComponents/physicsSolvers/wavePropagation/AcousticWaveEquationSEM.cpp
Outdated
Show resolved
Hide resolved
The .sgy are removed now. |
…ion of GEOSX node extraction
Hello everyone, @rrsettgast @corbett5 @francoishamon |
First order Spectral Element Method (SEM) for the second order acoustic wave equation.
In this PR we propose the first version of the acoustic wave solver using the SEM.
The space discretization is performed using the finite element implementation provide in GEOSX. For the time integration, we use first order central finite difference scheme.
We propose an implementation with a first order Absorbing Boundary Condition (ABC).
We can also specify a free surface using the geometry boxes and field specification in the xml file.
The source injected is assumed to be a Dirac at one point inside the computational domain. It coordinate must be specified in the xml file and should be located inside one of the mesh element. It is possible to specify more than one coordinate, each coordinate will be treated as an independent source point.
Once the sources coordinate are specified, it is mandatory to specify the central time frequency for the evaluation of a Ricker function.
As for the source, the receivers locations must be specified in xml file as well.
Related to https://github.com/GEOSX/integratedTests/pull/128
sem_for_time_acoustic_equation.pdf