Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogg Opus is fully supported from iOS 18.4 and macOS 15.4 Sonoma onwards #7284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Schweinepriester
Copy link
Contributor

@Schweinepriester Schweinepriester commented Mar 13, 2025

Ready to merge, imho!


See discussion below, insights have changed since posting 😅


Following #7282 I now tried to actually test:

While https://wpt.fyi/results/?label=master&product=chrome%5Bexperimental%5D&product=edge%5Bexperimental%5D&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&q=opus sees changes

image

the first example on https://tests.caniuse.com/opus continues to not work

image

and neither does "Example of use in a web page" on https://opus-codec.org/examples/

image

All tests done on macOS 14.7.4 using Safari_18.4_for_macOS_Sonoma_beta_3.dmg.

As such, revert the changes from #7282.

CC @jensimmons in case I missed something or support needs macOS 15 or the like.

@jensimmons
Copy link
Contributor

Yes, macOS 15.4 Sonoma is required — or iOS/iPadOS 18.4, visionOS 2.4.

@Schweinepriester
Copy link
Contributor Author

Thank you, I shall test and adjust the PR accordingly!

@jyavenard
Copy link

For added clarity:
Opus is an audio codec. It can be used in the Ogg, WebM and MP4 containers.

Safari supports opus in webm and mp4 on all platforms.
Opus in Ogg is supported from Sonoma and iOS 18. Maybe the title of the test should be improved for clarity.

@Schweinepriester
Copy link
Contributor Author

thank you both for clarifying!

Opus is an audio codec. It can be used in the Ogg, WebM and MP4 containers.

aye, and https://tests.caniuse.com/opus tests all three - unfortunately only visible on hover, so here's a screenshot of the DOM:

image

though, as I've only just now learned via https://en.wikipedia.org/wiki/Opus_(audio_format)#Containers

Opus was originally specified for encapsulation in Ogg containers, specified as audio/ogg; codecs=opus, and for Ogg Opus files the .opus filename extension is recommended.

i.e., at least confusing to me, that .opus is Opus in Ogg 😅

@Schweinepriester Schweinepriester marked this pull request as draft March 13, 2025 23:40
@jensimmons
Copy link
Contributor

This PR (at the moment) basically resets Safari back to only supporting in WebM. Which is not correct. Safari 18.4 adds support for Opus in Ogg, for macOS Sequoia 15.4 and above, as well as iOS, iPadOS, and visionOS.

Also, I expect we have had support for Opus in MP4 for some time, but am looking into since when.

@Schweinepriester
Copy link
Contributor Author

This PR (at the moment) basically resets Safari back to only supporting in WebM. Which is not correct. Safari 18.4 adds support for Opus in Ogg, for macOS Sequoia 15.4 and above, as well as iOS, iPadOS, and visionOS.

yepyep, working on adjusting o7

@Schweinepriester Schweinepriester changed the title Opus file support didn't actually change for Safari 18.4 Ogg Opus is fully supported from iOS 18.4 and macOS 15.4 Sonoma onwards Mar 13, 2025
@Schweinepriester
Copy link
Contributor Author

Can confirm that Ogg Opus works on iPadOS 18.4:

iPadOS 18.3:

IMG_0004

iPadOS 18.4

IMG_0005

🚀

As such, PR adjusted!

@Schweinepriester Schweinepriester marked this pull request as ready for review March 14, 2025 00:02
@jensimmons
Copy link
Contributor

Footnotes 1, 2, and 3 need to be update to reflect support for MP4. Maybe it should say doesn't support Ogg Opus instead of does support?? (I'm too tired to tell atm.) Something more than

Supported in a WebM container (all bitrates).

Because it was supported in WebM and MP4 during all that time.

(I can take a fresh look tomorrow with a better suggestion.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants