-
-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swage Theme #2069
Add Swage Theme #2069
Conversation
Add a new Theme to FreshRSS
Hello @pattems |
Add additional line to Credits
I've updated the credits. I'll get a dev branch instance set up this evening and see if I can get those glitches ironed out; I haven't looked at diffs yet, but I suspect I know what's going on and that it'll be pretty easy to straighten out. To be clear, is the second glitch you found also with the dev branch? |
Yes indeed, my tests were all done in the dev branch. I think the easiest for you is just to merge your /dev in your /master so you can keep your current PR. |
Add Icon was missing from theme.
That should hopefully take care of things! |
Looks perfect. Thanks again 😃 |
I fixed the bug with the config page; it was caused by being a little over-zealous with my last fix, along with the menu width issue. Since this pull request has been merged, do I need to open a new one to get the changes to you? I'm a little unfamiliar with git operations here. |
Yes, a new PR is the way to go! :-) |
Edit : Hello !! @Alkarex : i see that the CSS now enable the merg of the 2 upper bars + the logo can now be place in the left pane, as I suggested inhttps://github.com//issues/1983 Edit2 : thanks |
@GLLM I am not sure to understand your question. The new theme that @pattems has kindly provided does that with pure CSS (you can check the precise CSS rules in the source or in your browser's Web inspector), taking advantage of absolute position, fixed, table layout, etc. It is possible to move any element anywhere on the page. https://github.com//issues/1983 was more about providing some options to change those things in existing themes, but with this nice new Swage theme, I do not think it is needed any more. |
@pattems Please do not hesitate to ask if you are facing any problem with the git flow |
Hello @pattems, thanks for this superb theme! I use it and it's perfect! |
@Alwaysin You're most welcome! It's good to hear other people are enjoying my work. The configure-feeds buttons glitch is regrettable, but it's not a problem I can think of any way to really practically tackle with just CSS. It should be a fixable problem though, and I'll look into it as soon as time allows. Good call on highlighting the menu you're in; that didn't even occur to me, but I'll certainly stick it on my to-do list. |
@pattems Feel free to make new pull requests. Those will be included in the next minor release 1.12.1. |
@pattems I've just noticed that the login screen using your theme is kinda weird ("Login" cut off, FreshRSS is white on white so not visible, and boxes not visible enough I think): |
@Alwaysin good catch. Two of those three should be simple fixes. I'm not sure about the logo, but I think that should be fairly trivial as well. I'm a bit swamped at the moment, but I should have a PR to fix that out by the end of the weekend. |
* Fix for #1620 * Swage login tweaks #2069 (comment) * Swage tweaks for Mobile
* Add Swage Theme Add a new Theme to FreshRSS * Update Credits Add additional line to Credits * CSS Fixes Fix glitches in CSS. * Add Missing Icon Add Icon was missing from theme.
* Fix for FreshRSS#1620 * Swage login tweaks FreshRSS#2069 (comment) * Swage tweaks for Mobile
* Add Swage Theme Add a new Theme to FreshRSS * Update Credits Add additional line to Credits * CSS Fixes Fix glitches in CSS. * Add Missing Icon Add Icon was missing from theme.
* Fix for FreshRSS#1620 * Swage login tweaks FreshRSS#2069 (comment) * Swage tweaks for Mobile
Add a new Theme to FreshRSS.
This theme is a bit of a UI departure from other themes, especially on mobile: