Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swage Theme #2069

Merged
merged 5 commits into from
Oct 24, 2018
Merged

Add Swage Theme #2069

merged 5 commits into from
Oct 24, 2018

Conversation

pattems
Copy link
Contributor

@pattems pattems commented Oct 22, 2018

Add a new Theme to FreshRSS.

This theme is a bit of a UI departure from other themes, especially on mobile:

original

capture

Add a new Theme to FreshRSS
@Alkarex Alkarex added the UI 🎨 User Interfaces label Oct 23, 2018
@Alkarex Alkarex added this to the 1.12.0 milestone Oct 23, 2018
@Alkarex Alkarex changed the base branch from master to dev October 23, 2018 07:23
@Alkarex
Copy link
Member

Alkarex commented Oct 23, 2018

Hello @pattems
This looks really great! Many thanks for your contribution 👍
Your theme will be included in FreshRSS 1.12, which should be released in the coming days.
Could you please add one line for you in https://github.com/FreshRSS/FreshRSS/blob/dev/CREDITS.md ?

@Alkarex
Copy link
Member

Alkarex commented Oct 23, 2018

Not a big deal, but it looks like there is a couple of glitches in the /dev branch (which is the branch where the next version of FreshRSS are baked)

image

image

@Alkarex
Copy link
Member

Alkarex commented Oct 23, 2018

Another little glitch, when scrolling:

image

Add additional line to Credits
@pattems
Copy link
Contributor Author

pattems commented Oct 23, 2018

I've updated the credits. I'll get a dev branch instance set up this evening and see if I can get those glitches ironed out; I haven't looked at diffs yet, but I suspect I know what's going on and that it'll be pretty easy to straighten out.

To be clear, is the second glitch you found also with the dev branch?

@Alkarex
Copy link
Member

Alkarex commented Oct 23, 2018

Yes indeed, my tests were all done in the dev branch. I think the easiest for you is just to merge your /dev in your /master so you can keep your current PR.

Fix glitches in CSS.
Add Icon was missing from theme.
@pattems
Copy link
Contributor Author

pattems commented Oct 24, 2018

That should hopefully take care of things!

@Alkarex
Copy link
Member

Alkarex commented Oct 24, 2018

Looks perfect. Thanks again 😃

@Alkarex Alkarex merged commit 7de31bb into FreshRSS:dev Oct 24, 2018
@Alkarex
Copy link
Member

Alkarex commented Oct 24, 2018

Ups, I had not noticed, but there is a color bug in the configuration pages, making the text unreadable:

image

A few more suggestions for a future improvement:

Make input fields more visible. E.g.

image

Check menu width / layout with other languages:

image

Alkarex added a commit that referenced this pull request Oct 24, 2018
@pattems
Copy link
Contributor Author

pattems commented Oct 24, 2018

I fixed the bug with the config page; it was caused by being a little over-zealous with my last fix, along with the menu width issue. Since this pull request has been merged, do I need to open a new one to get the changes to you? I'm a little unfamiliar with git operations here.

@Frenzie
Copy link
Member

Frenzie commented Oct 25, 2018

Yes, a new PR is the way to go! :-)

@Alkarex Alkarex mentioned this pull request Oct 25, 2018
@GLLM
Copy link

GLLM commented Oct 26, 2018

Edit : Hello !!

@Alkarex : i see that the CSS now enable the merg of the 2 upper bars + the logo can now be place in the left pane, as I suggested inhttps://github.com//issues/1983
What has enabled this ?
I'm very interested :) :)

Edit2 : thanks

@Alkarex
Copy link
Member

Alkarex commented Oct 26, 2018

@GLLM I am not sure to understand your question. The new theme that @pattems has kindly provided does that with pure CSS (you can check the precise CSS rules in the source or in your browser's Web inspector), taking advantage of absolute position, fixed, table layout, etc. It is possible to move any element anywhere on the page. https://github.com//issues/1983 was more about providing some options to change those things in existing themes, but with this nice new Swage theme, I do not think it is needed any more.

@Alkarex
Copy link
Member

Alkarex commented Oct 26, 2018

@pattems Please do not hesitate to ask if you are facing any problem with the git flow

@pattems pattems mentioned this pull request Oct 26, 2018
@Alwaysin
Copy link
Contributor

Alwaysin commented Oct 28, 2018

Hello @pattems, thanks for this superb theme! I use it and it's perfect!
The menu is indeed better in french with you latest commit but there is another minor glitch:
image
I also had unreadable text on administration pages and it went away now. Minor suggestion is to highlight the menu in which you are, it would be more practical.
Thansk gain!

@pattems
Copy link
Contributor Author

pattems commented Oct 28, 2018

@Alwaysin You're most welcome! It's good to hear other people are enjoying my work.

The configure-feeds buttons glitch is regrettable, but it's not a problem I can think of any way to really practically tackle with just CSS. It should be a fixable problem though, and I'll look into it as soon as time allows.

Good call on highlighting the menu you're in; that didn't even occur to me, but I'll certainly stick it on my to-do list.

@Alkarex
Copy link
Member

Alkarex commented Oct 28, 2018

@pattems Feel free to make new pull requests. Those will be included in the next minor release 1.12.1.

@Alwaysin
Copy link
Contributor

Alwaysin commented Nov 1, 2018

@pattems I've just noticed that the login screen using your theme is kinda weird ("Login" cut off, FreshRSS is white on white so not visible, and boxes not visible enough I think):
image

@pattems
Copy link
Contributor Author

pattems commented Nov 3, 2018

@Alwaysin good catch. Two of those three should be simple fixes. I'm not sure about the logo, but I think that should be fairly trivial as well. I'm a bit swamped at the moment, but I should have a PR to fix that out by the end of the weekend.

pattems added a commit to pattems/FreshRSS that referenced this pull request Nov 12, 2018
@pattems pattems mentioned this pull request Nov 12, 2018
Alkarex pushed a commit that referenced this pull request Nov 13, 2018
* Fix for #1620

* Swage login tweaks

#2069 (comment)

* Swage tweaks for Mobile
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
* Add Swage Theme

Add a new Theme to FreshRSS

* Update Credits

Add additional line to Credits

* CSS Fixes

Fix glitches in CSS.

* Add Missing Icon

Add Icon was missing from theme.
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
* Fix for FreshRSS#1620

* Swage login tweaks

FreshRSS#2069 (comment)

* Swage tweaks for Mobile
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Add Swage Theme

Add a new Theme to FreshRSS

* Update Credits

Add additional line to Credits

* CSS Fixes

Fix glitches in CSS.

* Add Missing Icon

Add Icon was missing from theme.
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Fix for FreshRSS#1620

* Swage login tweaks

FreshRSS#2069 (comment)

* Swage tweaks for Mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants