feat: Improve client/source schema validation generation and error handling #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxxMD
added
enhancement
FoxxMD
force-pushed
the
validateGranular
branch
from
45eb316 to
24774ad
Compare
…ndling * Use runtime-generated schemas * Ensures validated schemas always match code * Can use schemas for individual source/clients without having to generate files * catch invididual validation errors and log instead of crashing * refactor validation error output into chained error instead of as individual log statements to improve clarity
* Add suite for testing client/source parsing and validation * Additionally, use example configs for two-birds-one-stone checking they are valid * Refactor sources init as separate step from component building
* Add missing sources to dual configs * Fix slug type for webscrobbler example
* Prevents app from crashing due to only one thing going wrong * Will be used for testing error handling in the future
Don't use ts-node for json-schema
FoxxMD
force-pushed
the
validateGranular
branch
from
f439e21 to
6b92920
Compare
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Please delete options that are not relevant.
Describe your changes
Will also fix the crash from #199 but not the validation error.