Consider also "maven.surefire.debug" environment variable while decid…

[skivol]

…ing if we are debugging

• to make debugging a more seamless process if started from command line using maven.

[splitfeed]

Nice! 👍
Could we get some test coverage here as well?

[skivol]

Looks like some unrelated test failed ("shouldRetryOnFullConnectionPool", https://travis-ci.org/FortnoxAB/reactive-wizard/jobs/421932467), but can try increasing the coverage anyway :)

[codecov]

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage     83.81%   83.81%           
- Complexity     1086     1088    +2     
=========================================
  Files           137      137           
  Lines          3064     3064           
  Branches        370      369    -1     
=========================================
  Hits           2568     2568           
  Misses          357      357           
  Partials        139      139

Impacted Files	Coverage Δ	Complexity Δ
...java/se/fortnox/reactivewizard/util/DebugUtil.java	50% <50%> (ø)	4 <2> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee10159...0af5b0a. Read the comment docs.

[skivol]

How does one locally check that coverage/complexity goals are met? (mvn verify seems to pass just fine)

[splitfeed]

I don't know if or how you can verify the codecov checks without pushing, but the failing tests are due to some flakyness. I reported one of these in #70, but it doesn't seem to be limited to that single test any longer.

[skivol]

Can we run the tests once again? :)

[skivol]

Any ideas on how to make "codecov/patch" happy? (don't know if kata-containers/tests#508 suggest a proper approach, but anyway :) )

[splitfeed]

It looks strange, the coverage seems good to me. I'll just merge this :)

[skivol]

Thanks :)
(Technically codecov-patch checks are maybe ok (but I don't understand how they work and whether it was possible to meet them in this case))

[skivol]

@splitfeed, so when is the next release? :)