Add option to ignore editor tab key handling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlande
commented
Jun 12, 2017
| @@ -15,6 +15,10 @@ export function LiveEditor(props: HTMLAttributes<HTMLElement>): JSX.Element | |||
| export function LiveError(props: HTMLAttributes<HTMLElement>): JSX.Element | |||
| export function LivePreview(props: HTMLAttributes<HTMLElement>): JSX.Element | |||
|
|
|||
| export class Editor extends Component<HTMLAttributes<HTMLElement>, {}>{} | |||
| export type EditorProps = HTMLAttributes<HTMLElement> & { | |||
There was a problem hiding this comment.
I'm not familiar with TypeScript at all, so let me know if I screwed this up somehow.
There was a problem hiding this comment.
I think that's the correct place 👍
kitten
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a prop to
Editorto allow you to disable the tab key handling. The default behavior is nice for a lot of cases, but it's a focus trap for keyboard users navigating through a page with an editor in it.