Feature/chat history #715
Closed
Feature/chat history #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owise into feature/ChatHistory
chungyau97
commented
Aug 22, 2023
isikhi
reviewed
Aug 29, 2023
| }) | ||
|
|
||
| // Send input message and get prediction result (Internal) | ||
| this.app.post('/api/v1/internal-prediction/:id', async (req: Request, res: Response) => { | ||
| await this.processPrediction(req, res, socketIO, true) | ||
| await this.processPrediction(req, res, socketIO, 'internal') |
There was a problem hiding this comment.
This and similar of this ('internal', 'external') can be enum, like ChatTypes.internal instead of hardcoding
There was a problem hiding this comment.
The only feedback I can give for mr instead of code pices, here would be to get variables from an enum, or a common constant, instead of hardcoded texts. I think it will benefit in the future.
isikhi
reviewed
Aug 29, 2023
| return node.data.category === 'Memory' | ||
| }) | ||
|
|
||
| return memoryNode ? memoryNode.data.label : undefined |
There was a problem hiding this comment.
return memoryNode?.data?.label
more readable but no harm
This was referenced Sep 4, 2023
Merged
|
@HenryHengZJ or @chungyau97 - Can this be made available soon? I'm interesting in the sessionID piece of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
FlowiseChatEmbed PR #27
Results:
Database
Zep Memory specify the same sessionId
QnA