Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Sdk Suppress Handling #2094

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Jul 20, 2021

Fixes #2053

Test Plan

How do we know the code works?

  1. Run Flank with SdkSuppress methods (ex. use test_projects/android/app_sdksuppress) project
  2. Play with different API versions(using YAML device->version and check if flank has any problems)

Checklist

  • Unit tested
  • Tests project added

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2021

Timestamp: 2021-07-23 12:20:13
Buildscan url for ubuntu-workflow run 1059607182
https://gradle.com/s/zbshijellycv2

@piotradamczyk5 piotradamczyk5 force-pushed the #2053_added_sdksuppress_handling branch from 595722a to 6d841d4 Compare July 21, 2021 20:59
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review July 21, 2021 21:21
@bootstraponline bootstraponline force-pushed the #2053_added_sdksuppress_handling branch from f918898 to d037662 Compare July 22, 2021 15:31
@mergify
Copy link

mergify bot commented Jul 22, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@bootstraponline bootstraponline force-pushed the #2053_added_sdksuppress_handling branch from d037662 to 6006c44 Compare July 23, 2021 12:12
@mergify mergify bot merged commit 0b46bf2 into master Jul 23, 2021
@mergify mergify bot deleted the #2053_added_sdksuppress_handling branch July 23, 2021 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flank does not handle @SdkSuppress annotation correctly
4 participants