Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added firebase event to Mixpanel #2088

Merged
merged 10 commits into from
Jul 21, 2021
Merged

feat: Added firebase event to Mixpanel #2088

merged 10 commits into from
Jul 21, 2021

Conversation

adamfilipow92
Copy link
Contributor

Fixes #2087

Test Plan

How do we know the code works?

Mixpanel shows new event, all tests pass.

Checklist

  • Documented
  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2021

Timestamp: 2021-07-21 07:30:19
Buildscan url for ubuntu-workflow run 1051655362
https://gradle.com/s/4rh22mbtdhwlk

@Sloox Sloox requested review from Sloox, piotradamczyk5 and jan-goral and removed request for Sloox July 19, 2021 14:15
@bootstraponline bootstraponline force-pushed the 2087-new-firebase-event branch from 1e9360c to 285a6a2 Compare July 19, 2021 14:18
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes :)

@Sloox Sloox self-requested a review July 21, 2021 07:23
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commited the changes and approved 👍

@Sloox Sloox enabled auto-merge (squash) July 21, 2021 07:24
@Sloox Sloox merged commit 156910c into master Jul 21, 2021
@Sloox Sloox deleted the 2087-new-firebase-event branch July 21, 2021 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New firebase test lab run Mixpanel event
4 participants