pass full commit sha through release command (#2445)

Flank · Oct 23, 2023 · dcbe4ae · dcbe4ae
1 parent 6784101
commit dcbe4ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -52,8 +52,6 @@ jobs:
             else
               echo "RELEASE_TAG=flank-snapshot" >> $GITHUB_ENV
               echo "MVN_VERSION=master-SNAPSHOT" >> $GITHUB_ENV
-              git_short_hash=$(git rev-parse --short "$GITHUB_SHA")
-              echo "GIT_SHORT_HASH=$(echo $git_short_hash)" >> $GITHUB_ENV
           fi;
 
     - name: Store version variables to file
@@ -84,7 +82,7 @@ jobs:
       if: ${{ env.RELEASE_TAG == 'flank-snapshot' }}
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      run: flankScripts github make_release --input-file=./test_runner/build/libs/flank.jar --git-tag=$RELEASE_TAG --commit-hash=$GIT_SHORT_HASH --snapshot
+      run: flankScripts github make_release --input-file=./test_runner/build/libs/flank.jar --git-tag=$RELEASE_TAG --commit-hash=$GITHUB_SHA --snapshot
 
     - name: Release stable
       if: startsWith(github.ref, 'refs/tags/v')

diff --git a/flank-scripts/src/main/kotlin/flank/scripts/ops/github/ReleaseFlank.kt b/flank-scripts/src/main/kotlin/flank/scripts/ops/github/ReleaseFlank.kt
@@ -50,7 +50,7 @@ private fun hubStableSnapshotCommand(path: String, gitTag: String, commitHash: S
         "-p", // create a prerelease
         "-t", "Flank $gitTag",
         "-n", "Snapshot release for commit $commitHash",
-
+        "--target", "$commitHash",
     )
 
 private fun hubStableReleaseCommand(path: String, gitTag: String, token: String) =