Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comment about ordering of addresses in wasmplus #107

Merged
merged 7 commits into from
Sep 7, 2023
Merged

docs: add comment about ordering of addresses in wasmplus #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2800b58
chore: Added comment about ordering of addresses
Kynea0b Sep 5, 2023
ea81490
chore: add this pr to change.log
Kynea0b Sep 5, 2023
975777a
fix: fix singular
Kynea0b Sep 5, 2023
8a5b30f
fix: fix pr title
Kynea0b Sep 5, 2023
7fa4ad0
fix: fix singular
Kynea0b Sep 5, 2023
113db50
fix: Correct uppercase letters to lowercase letters
Kynea0b Sep 5, 2023
74aef72
fix: Correct to specify the type of elements in List of addresses
Kynea0b Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
* [\#54](https://github.com/Finschia/wasmd/pull/54) add documentation about errors (codespace and codes)
* [\#92](https://github.com/Finschia/wasmd/pull/92) modify links in x/wasmplus README.md
* [\#103](https://github.com/Finschia/wasmd/pull/103) add clarifications to the order of list response in query
* [\#107](https://github.com/Finschia/wasmd/pull/107) add comment about ordering of addresses in wasmplus


## [v0.1.4](https://github.com/Finschia/wasmd/releases/tag/v0.1.4) - 2023.05.22
Expand Down
8 changes: 4 additions & 4 deletions docs/proto/proto-docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,10 +1506,10 @@ QueryInactiveContractsResponse is the response type for the
Query/InactiveContract RPC method.


| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `addresses` | [string](#string) | repeated | addresses is the inactive address list |
| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response |
| Field | Type | Label | Description |
| ----- | ---- | ----- |---------------------------------------------------------------------------------|
| `addresses` | [string](#string) | repeated | addresses is the inactive address list of strings, in ascending order of byte format |
| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response |



Expand Down
2 changes: 1 addition & 1 deletion proto/lbm/wasm/v1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ message QueryInactiveContractsRequest {
// QueryInactiveContractsResponse is the response type for the
// Query/InactiveContract RPC method.
message QueryInactiveContractsResponse {
// addresses is the inactive address list
// addresses is the inactive address list of strings, in ascending order of byte format
repeated string addresses = 1;

// pagination defines the pagination in the response
Expand Down
2 changes: 1 addition & 1 deletion x/wasmplus/types/query.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.