Use osmosis-rust as finschia-wasm #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kynea0b
force-pushed
the
switch-osmosis-to-finschia
branch
from
eceb56d to
ba33ca3
Compare
…ry osmosis variable
Need to consider testing for finschia
- packages/finschia-std-derive/tests - packages/finschia-std/tests The above two tests need to be recreated as tests for finschia. Finschia#2
|
Can't you rewrite tests in c1c2d65 rather than delete them? |
…e which belongs to foundation module
Kynea0b
force-pushed
the
switch-osmosis-to-finschia
branch
from
c5b5b9a to
eeae702
Compare
|
@loloicci Thanks. I added tests for finschia. PTAL |
loloicci
reviewed
Jan 9, 2024
loloicci
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To use osmosis-rust as finschia-wasm, change the submodule and package name.
changes
This PR has the following changes:
dependencies/and.gitmodulesto submodule for finschia (Along with this, the tag specified in proto-build's main.rs has been changed to the finschia repository tag.)remaining issues
These were deleted in order to consider the ones for finschia from scratch.
This is commented out because it is necessary to replace it with a typical message under
finschia-std/typesand rewrite the test.#2