-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create ERRORS.md for x/module #1059
Conversation
163bd49
to
d1c1092
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 62.02% 62.02%
=======================================
Files 656 656
Lines 78937 78937
=======================================
Hits 48962 48962
Misses 27286 27286
Partials 2689 2689 |
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
d1c1092
to
a640923
Compare
Signed-off-by: 170210 <j170210@icloud.com>
Please add go.mod in tools/error_doc. |
How about adding link to x/ERRORS.md in x/README.md? |
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
d2707cf
to
7f64fdd
Compare
Signed-off-by: 170210 <j170210@icloud.com>
7f64fdd
to
384316e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming the file to error_docs_generator.go
?
Signed-off-by: 170210 <j170210@icloud.com>
0858476
to
d5e2d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: 170210 <j170210@icloud.com>
dd4d6f8
to
42c625c
Compare
* main: chore(deps): Bump github.com/prometheus/client_golang (Finschia#1132) feat: add update-censorship cmd to x/foundation cli (Finschia#1121) chore(deps): Bump actions/checkout from 3 to 4 (Finschia#1110) chore(deps): Bump actions/cache from 3.3.1 to 3.3.2 (Finschia#1119) chore(deps): Bump docker/build-push-action from 4 to 5 (Finschia#1123) chore(deps): Bump docker/login-action from 2 to 3 (Finschia#1124) chore(deps): Bump docker/metadata-action from 4 to 5 (Finschia#1125) chore(deps): Bump github.com/hashicorp/golang-lru from 0.5.5-0.20210104140557-80c98217689d to 1.0.2 (Finschia#1074) chore(deps): Bump github.com/go-kit/kit from 0.12.0 to 0.13.0 (Finschia#1097) chore(deps): Bump golang.org/x/crypto from 0.11.0 to 0.13.0 (Finschia#1111) chore: fix tag comments in github actions workflow docker.yml (Finschia#1078) docs: update links in x/foundation README.md (Finschia#1120) docs: create ERRORS.md for x/module (Finschia#1059) # Conflicts: # CHANGELOG.md # Makefile # go.mod # go.sum
* chore: create an automatic error document generation module Signed-off-by: 170210 <j170210@icloud.com> * docs: generate ERRORS.md for x/module Signed-off-by: 170210 <j170210@icloud.com> * chore: add a ci to check generated error docs up-to-date Signed-off-by: 170210 <j170210@icloud.com> * chore: update changelog Signed-off-by: 170210 <j170210@icloud.com> * refactor: fix for lint Signed-off-by: 170210 <j170210@icloud.com> * style: format yml file Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for review Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for review Signed-off-by: 170210 <j170210@icloud.com> * fixup: refactor by comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com>
Description
This PR has following changes.
closes: #942
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml