This repository was archived by the owner on Jan 1, 2020. It is now read-only.
Common cases #5
Open
Common cases #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expede
commented
Apr 10, 2018
| Prehistory | Mint | Hold | Trade | | ||
|
|
||
| */ | ||
| contract PhaseValidator is TokenValidator { |
There was a problem hiding this comment.
NOTE TO SELF:
This actually makes sense in its own contract. We are probably going to have situations where certain users are exempt from certain phases and whatnot. Keeping these decomposed gives us the flexibility to call the parts that we need to. modifiers hardcode that logic per contract class, making it more difficult to extend. Broadly, this is good OO practice, but feels weird knowing this much about the contract in the validator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Common Deal tokens and validators