minor-feat: any column can be specified #51
Merged
+482
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rspecの結果 F-00168-Mac: ~/workspace/shiroyagi (feat/any_column_can_be_specified %=)
Randomized with seed 52170
*................................................................................................................................
Pending: (Failures listed here are expected and do not affect your suite's status)
1) User add some examples to (or delete) /Users/kota.nakatsubo/workspace/shiroyagi/spec/models/user_spec.rb
# Not yet implemented
# ./spec/models/user_spec.rb:4
Finished in 0.91994 seconds (files took 2.45 seconds to load)
129 examples, 0 failures, 1 pending
Randomized with seed 52170 |
2bo
commented
Jul 26, 2022
| @@ -0,0 +1,417 @@ | |||
| require 'rails_helper' | |||
|
|
|||
There was a problem hiding this comment.
テストの中身は以下をコピーして、カラム、モデル名を変更しただけ
spec/models/message_spec.rb
satom9to5
reviewed
Jul 26, 2022
lib/shiroyagi/acts_as_shiroyagi.rb
Outdated
Comment on lines
9
to
12
| # NOTE: override this method change column to use read management | ||
| def read_management_column_name | ||
| :read_at | ||
| end |
There was a problem hiding this comment.
ARの self.table_name = :hoge みたいな感じで設定できた方が良さそうです
シンプルに書けばこんな感じ？
def read_management_column_name
@read_management_column_name
end
def read_management_column_name=(column_name)
@read_management_column_name = column_name
end
There was a problem hiding this comment.
もしくはdeviseの devise :hoge を参考に、 acts_as_shiroyagi read_management_column_name: :hoge みたいな？
https://github.com/heartcombo/devise/blob/main/lib/devise/models.rb#L71-L111
There was a problem hiding this comment.
@satom9to5
5c43143
で修正しました
シンプル方針で
2bo
changed the title
satom9to5
reviewed
Jul 26, 2022
lib/shiroyagi/acts_as_shiroyagi.rb
Outdated
|
|
||
| def mark_as_read | ||
| update(read_at: Time.current) if unread? | ||
| update(self.class.read_management_column_name => Time.current) if unread? |
There was a problem hiding this comment.
以下のprivate method追加した方が見やすいかと
def read_management_column_name
self.class.read_management_column_name
end
There was a problem hiding this comment.
@satom9to5
bf58746
で修正しました
satom9to5
reviewed
Jul 26, 2022
lib/shiroyagi/acts_as_shiroyagi.rb
Outdated
| end | ||
|
|
||
| def read? | ||
| read_at.present? | ||
| send(self.class.read_management_column_name).send('present?') |
There was a problem hiding this comment.
Suggested change
| send(self.class.read_management_column_name).send('present?') | |
| send(self.class.read_management_column_name).present? |
There was a problem hiding this comment.
@satom9to5
6b1e611
で修正しました
satom9to5
reviewed
Jul 26, 2022
lib/shiroyagi/acts_as_shiroyagi.rb
Outdated
| def acts_as_shiroyagi(options = {}) | ||
| @read_management_column_name = options[:column].to_sym |
There was a problem hiding this comment.
Suggested change
| @read_management_column_name = options[:column].to_sym | |
| @read_management_column_name = options[:column].to_sym if options[:column].present? |
satom9to5
approved these changes
Jul 26, 2022
|
@deraru さんにも見てもらったほうがいいですね。 |
|
@deraru |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
任意のカラムを既読管理用に指定できるようにしました
デフォルトは
read_atです