-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create manifest files separately and reference in bundle plugin, THEN shade in the new manifest for Jakarta separately before install #136
Conversation
… shade in the new manifest for jakarta separately before install #132
All updated and generated files attached |
@@ -50,6 +50,9 @@ ${project.groupId}.annotation.*;version=${project.version} | |||
<plugin> | |||
<groupId>org.moditect</groupId> | |||
<artifactId>moditect-maven-plugin</artifactId> | |||
<configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this to parent pom, so should not be needed here (at least seemed to work when I tried)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't placing in the META-INF/vesrions folder :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmh. Seemed to, for me, but I can double-check after merging.
Looks good: the only tangible question is whether "jvm11" setting has to be on child poms and not on parent one? (I changed that recently and parent setting seemed to work). |
Oh bloody hell. I think this royally messed up release process and resulted in corrupt 2.12.2 release :-( So we get this:
where there somehow is ".pom.asc" but no actual ".pom" entry. Not sure how/why Sonatype Nexus accepts that; nor how it ends up, but that is consistent behavior. Any chance this is due to that 0.0.1 version of a plugin? |
Oh I don't think that is the case - We use the same in the primefaces release, and I deploy quite a lot through - The asc is the signing piece right, the gpg file signatures? I got a few fails yesterday on the sonar deploys wondering if it's there or otherwise (https://jwebmp.com/teamcity) |
It just seems very weird that only artifacts that use the post-processing failed; and that I have not observed these before. Will try to test locally when I have time today. At the same time, JAX-RS repo is the very last thing pushed so that could be related to unlucky timing. And yes, .asc I think is the signature... so it'd have to be done based on existing file wouldn't it? |
@GedMarc Release plug-in pushes broken content reliably: I can see missing ".pom" after re-attempting 2.12.2 release. Odd part is that console has:
but UI does not show |
Hmmh. That's not good... I filed this: https://issues.sonatype.org/browse/MVNCENTRAL-6595 and hopefully Joel can shed some light on what's happening. |
Looks like release plug-in reliably and always uploads a set of artifacts that is missing .pom file; output contains nothing to indicate any problem (.pom files get created and uploaded seemingly just fine). So I am not sure there is anything sporadic about the problem -- I guess on plus side it can be repeated easily. |
Runs the bundle plugin twice, once for the creation of the original bundle, and again for the changes to the jakarta packing.
The manifest files are placed in target/jakarta and are picked up by the shading and replaces the javax manifest
#132