-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple implementations of ws.rs #121
Conversation
//Allow multiple implementations of ws.rs | ||
requires static javax.ws.rs.api; | ||
requires static java.ws.rs; | ||
requires static jakarta.ws.rs.api; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all 3 of these required? It would seem first and third were synonyms or... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GedMarc was hoping to clear this up, before releasing 2.10.2. So... are those all really needed? (wrt 1st and 3rd entries)
@cowtowncoder This one looks correct, |
@GedMarc Ok but I am still not clear why change is needed? Change to add |
So there's a few releases of the library, which includes
A nice example I like to use is servlet, where 2.5 is java.servlet, 3 is java.servlet-api and 4 is javax.servlet-api. To support all the different module naming, even though its the same library, you specify static to mark that it may be provided as any of these. JaxRS has the first two as you know between two different automatic-module-names, which looking at right now - actually have to add another one in case the latest is used xD I hope I've made sense! |
@GedMarc Ok... makes some sense, I am just struggling with conceptually thinking that everything in module-info is basically "and" (i.e. all of those must be provided). But seems like this is not the case. Anyway, since you trust these are needed I'll trust you & merge this. Just wanted to double-check. :) |
No description provided.