Fix #4788 : WRITE_ENUMS_TO_LOWERCASE overrides @JsonProperty
#4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Nov 8, 2024
| @@ -267,6 +241,22 @@ protected static Enum<?>[] _enumConstants(Class<?> enumCls) { | |||
| } | |||
| return enumValues; | |||
| } | |||
|
|
|||
| protected static String _findNameToUse(String explicitName, String otherName, boolean toLowerCase) { | |||
There was a problem hiding this comment.
I questioned for a second whether to lazy-initialize otherName param by passing a functional interface or something, but thought it would be overkill to start with.
There was a problem hiding this comment.
Agreed, I think it's ok to eagerly process things in this case. Should not be on critical path.
But also: good idea to think about that, to potentially avoid unnecessary computation.
1 task
cowtowncoder
reviewed
Nov 8, 2024
JooHyukKim
commented
Nov 8, 2024
cowtowncoder
approved these changes
Nov 8, 2024
|
Thanks! May I ask you to remove this comment also along the way @cowtowncoder ? I was a few seconds late 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves 4788