-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard-coded StreamReadConstraints
test variables to isolate change in jackson-core
itself
#3930
Merged
cowtowncoder
merged 5 commits into
FasterXML:2.15
from
JooHyukKim:Make-string-value-dynamic
May 15, 2023
Merged
Remove hard-coded StreamReadConstraints
test variables to isolate change in jackson-core
itself
#3930
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1ed33de
Update StreamReadStringConstraintsTest.java
JooHyukKim b898bda
Make test excessive values dynamic
JooHyukKim 7fe9b91
Update DeepNestingUntypedDeserTest.java
JooHyukKim 25fb09a
Remove unnecessary changes.
JooHyukKim 2b2fa5a
simplify value.
JooHyukKim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not going to make StreamReadConstraints.DEFAULT_MAX_DEPTH <=0 - this complicated statement is unnecessary - use
TOO_DEEP_NESTING = StreamReadConstraints.DEFAULT_MAX_DEPTH * 10
- this goes for all the MAX valuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍🏻 thank you for the review. I also think it could simpler.