Minor post-junit5 conversion cleanup

FasterXML · Mar 22, 2024 · 2a86e11 · 2a86e11
1 parent 7cece7e
commit 2a86e11
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/src/test/java/com/fasterxml/jackson/core/json/JsonParserClosedCaseTest.java b/src/test/java/com/fasterxml/jackson/core/json/JsonParserClosedCaseTest.java
@@ -23,7 +23,7 @@
 public class JsonParserClosedCaseTest {
     private static final JsonFactory JSON_F = new JsonFactory();
 
-    private JsonParser parser;
+    JsonParser parser;
 
     /**
      * Creates a list of parsers to tests.

diff --git a/src/test/java/com/fasterxml/jackson/core/json/async/AsyncMissingValuesInArrayTest.java b/src/test/java/com/fasterxml/jackson/core/json/async/AsyncMissingValuesInArrayTest.java
@@ -16,8 +16,8 @@
 
 public class AsyncMissingValuesInArrayTest extends AsyncTestBase
 {
-    private JsonFactory factory;
-    private HashSet<JsonReadFeature> features;
+    JsonFactory factory;
+    HashSet<JsonReadFeature> features;
 
     public void initAsyncMissingValuesInArrayTest(Collection<JsonReadFeature> features) {
         this.features = new HashSet<>(features);

diff --git a/src/test/java/com/fasterxml/jackson/core/json/async/AsyncMissingValuesInObjectTest.java b/src/test/java/com/fasterxml/jackson/core/json/async/AsyncMissingValuesInObjectTest.java
@@ -16,8 +16,8 @@
 
 public class AsyncMissingValuesInObjectTest extends AsyncTestBase
 {
-    private JsonFactory factory;
-    private HashSet<JsonReadFeature> features;
+    JsonFactory factory;
+    HashSet<JsonReadFeature> features;
 
     public void initAsyncMissingValuesInObjectTest(Collection<JsonReadFeature> features) {
         this.features = new HashSet<>(features);

diff --git a/src/test/java/com/fasterxml/jackson/core/json/async/AsyncNonStdParsingTest.java b/src/test/java/com/fasterxml/jackson/core/json/async/AsyncNonStdParsingTest.java
@@ -4,8 +4,8 @@
 
 import com.fasterxml.jackson.core.*;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
+
 import com.fasterxml.jackson.core.async.AsyncTestBase;
 import com.fasterxml.jackson.core.json.JsonReadFeature;
 import com.fasterxml.jackson.core.testsupport.AsyncReaderWrapper;
@@ -357,9 +357,8 @@ private void _testNonStandardNameChars(JsonFactory f,
         p.close();
     }
 
-    @Disabled//this test was not executed with junit4. Now, with junit5 it is executed but fails -> disabled. TODO fix or remove
     @Test
-    void nonStandarBackslashQuotingForValues(int mode) throws Exception
+    void nonStandarBackslashQuotingForValues() throws Exception
     {
         _testNonStandarBackslashQuoting(0, 99);
         _testNonStandarBackslashQuoting(0, 6);