Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell support (config, workflow to detect/not fix) and make it fix few typos #638

Merged
merged 11 commits into from
Jan 16, 2025

Conversation

yarikoptic
Copy link
Contributor

Recreation of

against current main. Likely the last of the kind ;-)

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi wether whether",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'fetchin ' 'fetching '",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'agains the' 'against the'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
…(but ignoring overall fail due to ambigous ones)

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w || :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w -i 3 -C 2",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Contributor Author

oops -- fixed up that inline ignore now. lovely to see all the testing CI! ;)

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 45.46%. Comparing base (8e3952e) to head (bd9aa19).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
siibra/retrieval/datasets.py 0.00% 3 Missing ⚠️
siibra/volumes/volume.py 0.00% 3 Missing ⚠️
siibra/retrieval/requests.py 0.00% 2 Missing ⚠️
siibra/volumes/parcellationmap.py 0.00% 2 Missing ⚠️
siibra/volumes/providers/freesurfer.py 0.00% 2 Missing ⚠️
siibra/core/region.py 0.00% 1 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 0.00% 1 Missing ⚠️
siibra/features/feature.py 0.00% 1 Missing ⚠️
siibra/livequeries/query.py 0.00% 1 Missing ⚠️
siibra/retrieval/repositories.py 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   45.44%   45.46%   +0.01%     
==========================================
  Files          75       75              
  Lines        7196     7204       +8     
==========================================
+ Hits         3270     3275       +5     
- Misses       3926     3929       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek merged commit 0806285 into FZJ-INM1-BDA:main Jan 16, 2025
26 of 27 checks passed
@AhmetNSimsek
Copy link
Collaborator

Thanks @yarikoptic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants