Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: region.supported_spaces and region.mapped_in_space() #635

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

AhmetNSimsek
Copy link
Collaborator

fixes #239

@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Dec 19, 2024
@AhmetNSimsek AhmetNSimsek self-assigned this Dec 19, 2024
@AhmetNSimsek AhmetNSimsek force-pushed the maint_region_suuported_spaces branch from ccbdfa3 to 1d60e73 Compare December 20, 2024 12:31
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.44%. Comparing base (715eecc) to head (8e3952e).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
siibra/core/region.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   45.44%   45.44%   -0.01%     
==========================================
  Files          75       75              
  Lines        7198     7196       -2     
==========================================
- Hits         3271     3270       -1     
+ Misses       3927     3926       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek force-pushed the maint_region_suuported_spaces branch from 1d60e73 to 4b6da2e Compare December 20, 2024 13:10
@AhmetNSimsek AhmetNSimsek marked this pull request as draft December 20, 2024 18:58
@AhmetNSimsek AhmetNSimsek changed the title maint: region.supported_spaces and region.mapped_in_space()` maint: region.supported_spaces and region.mapped_in_space() Jan 8, 2025
@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review January 8, 2025 16:42
@AhmetNSimsek AhmetNSimsek merged commit a91a7b4 into main Jan 9, 2025
39 checks passed
@AhmetNSimsek AhmetNSimsek deleted the maint_region_suuported_spaces branch January 9, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.4] BigBrain is not listed in supported_spaces of julich 2.9 and 2.5 parcellations
2 participants