Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test region id uniqueness #631

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Test region id uniqueness #631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2462986
test: region id uniqueness
AhmetNSimsek Dec 10, 2024
4691351
Merge branch 'main' into test_region_id_uniqueness
AhmetNSimsek Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions e2e/core/test_parcellation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import siibra
import pytest
from siibra.core.parcellation import Parcellation

args = [
("waxholm v3", "neocortex", lambda region: region.name == "neocortex"),
Expand All @@ -23,3 +24,22 @@ def test_get_region(parc_spec, reg_spec, validator):
siibra.get_region(parc_spec, reg_spec)

raise e("Should be either Exception or callable")


def test_parc_id_uniqueness():
parcs = {p.name: p.id for p in siibra.parcellations}
assert len(set(parcs.values())) == len(parcs)


@pytest.mark.parametrize("parcellation", list(siibra.parcellations))
def test_region_id_uniqueness(parcellation: Parcellation):
ids = set()
duplicates = set()
for region in parcellation:
try:
assert region.id not in ids, f"'{region.id}' has a duplicate in {parcellation.name}."
except AssertionError:
duplicates.add(region.id)
ids.add(region)

assert len(duplicates) == 0, f"Folowing regions a duplicate IDs in {parcellation.name}:\n{duplicates}"
Loading