Volume subclass BrainStructure
#630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmetNSimsek
added
the
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 45.60% 45.64% +0.03%
==========================================
Files 75 75
Lines 7194 7184 -10
==========================================
- Hits 3281 3279 -2
+ Misses 3913 3905 -8 ☔ View full report in Codecov by Sentry. |
AhmetNSimsek
force-pushed
the
maint_volume_as_brainstructure
branch
from
d208226 to
e669b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During refactoring from v0.4axx to v1.0axx, it was decided to make
VolumeaLocationwhich is aBrainStructure. However, while aVolumeinstance can convey a kind of location in space, it does not possess the aspects of aLocationas siibra-python defines it. Therefore, it is updated as aBrainStructure.