Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use datasets of the spaces if templates don't have any specified #578

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

No description provided.

@AhmetNSimsek AhmetNSimsek requested a review from dickscheid March 10, 2024 16:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 50.27%. Comparing base (5a0e6b3) to head (a130272).
Report is 443 commits behind head on main.

Files Patch % Lines
siibra/core/space.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #578       +/-   ##
===========================================
+ Coverage   36.81%   50.27%   +13.45%     
===========================================
  Files          61       69        +8     
  Lines        5421     6711     +1290     
===========================================
+ Hits         1996     3374     +1378     
+ Misses       3425     3337       -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek merged commit 4aeccd6 into main Mar 11, 2024
27 checks passed
@AhmetNSimsek AhmetNSimsek deleted the enh_templates_use_datasets_of_space branch March 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants