Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fetch specific label from gii labels #574

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Mar 1, 2024

Test snippet:

import siibra
from nilearn import plotting
mp = siibra.get_map('julich 2.9', 'fsaverage')
mesh = mp.fetch('hoc1 left')
plotting.view_surf(
    surf_mesh=[mesh['verts'], mesh['faces']],
    surf_map=mesh['labels'],
    cmap=mp.get_colormap(),
    symmetric_cmap=False, colorbar=False
).open_in_browser()

@AhmetNSimsek AhmetNSimsek added the bug Something isn't working label Mar 1, 2024
@AhmetNSimsek AhmetNSimsek requested a review from xgui3783 March 1, 2024 09:41
@xgui3783
Copy link
Member

xgui3783 commented Mar 1, 2024

re: test snippet mp is not defined anywhere?

Copy link
Member

@xgui3783 xgui3783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes much more sense to add the code snippet in a test? since you already spent effort writing it in the PR?

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 50.32%. Comparing base (5a0e6b3) to head (342974e).
Report is 432 commits behind head on main.

Files Patch % Lines
siibra/volumes/providers/gifti.py 25.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #574       +/-   ##
===========================================
+ Coverage   36.81%   50.32%   +13.50%     
===========================================
  Files          61       69        +8     
  Lines        5421     6694     +1273     
===========================================
+ Hits         1996     3369     +1373     
+ Misses       3425     3325      -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update test to check other formats as well
@AhmetNSimsek AhmetNSimsek merged commit 6d600a2 into main Mar 1, 2024
27 checks passed
@AhmetNSimsek AhmetNSimsek deleted the fix_fetch_specific_giilabel branch March 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants