-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat feature.name
and reintorudce data
and plot()
for CompoundFeature
s
#568
Conversation
note: waiting on me (@xgui3783 ) to create a preview viewer/api instance |
8161268
to
35585fe
Compare
additional regression not covered by tests some features now have duplicated ids sample code (tested for 35585fe ): import siibra
siibra.cache.clear()
region = siibra.get_region("cortical layer", "1 left")
f, = siibra.features.get(region, "cell density profile")
print(len([_ for _ in f]), len({_.id for _ in f})) # prints 5 3 |
@AhmetNSimsek are the new commits meant to address #568 (comment) ? |
Indeed! I forgot to ping you, sorry. |
4bae557
to
b8b3bff
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
===========================================
+ Coverage 36.81% 51.64% +14.82%
===========================================
Files 61 74 +13
Lines 5421 7012 +1591
===========================================
+ Hits 1996 3621 +1625
+ Misses 3425 3391 -34 ☔ View full report in Codecov by Sentry. |
- `Compoundable._merge_elements` takes elements of a compound features and creates a feature of the same type to be used for averaged data and plotting. - Averaging implies that the data is derived so when it is accessed the first time, this will be conveyed to the user. Also, the figure titles will reflect the info (even if the user supplies a title)
…receptor. Update relevant tests
0179fc3
to
c432a11
Compare
9413bed
to
e0db4ef
Compare
…as implementation
fix: python closure is weird
fix: fix tally
fix: add assertion error message
fix: memory usage when warming the cache
This reverts commit 90ad7dd.
data
and averaged graphs decided to be added in the dev meeting on 22.02.2024Please use https://github.com/FZJ-INM1-BDA/siibra-configurations/tree/use_v04_feature_ids for configuration to test.