Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat feature.name and reintorudce data and plot() for CompoundFeatures #568

Merged
merged 27 commits into from
Apr 26, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Feb 26, 2024

Please use https://github.com/FZJ-INM1-BDA/siibra-configurations/tree/use_v04_feature_ids for configuration to test.

@AhmetNSimsek AhmetNSimsek added important maintenance Not a bug or breaking issue. Code maintenance related. urgent labels Feb 26, 2024
@xgui3783
Copy link
Member

note: waiting on me (@xgui3783 ) to create a preview viewer/api instance

@AhmetNSimsek AhmetNSimsek force-pushed the maint_featurenames_and_cfdata branch 2 times, most recently from 8161268 to 35585fe Compare February 26, 2024 15:52
@AhmetNSimsek AhmetNSimsek self-assigned this Feb 27, 2024
@xgui3783
Copy link
Member

xgui3783 commented Feb 27, 2024

additional regression not covered by tests

some features now have duplicated ids

sample code (tested for 35585fe ):

import siibra

siibra.cache.clear()

region = siibra.get_region("cortical layer", "1 left")

f, = siibra.features.get(region, "cell density profile")
print(len([_ for _ in f]), len({_.id for _ in f})) # prints 5 3

@xgui3783
Copy link
Member

xgui3783 commented Mar 8, 2024

@AhmetNSimsek are the new commits meant to address #568 (comment) ?

@AhmetNSimsek
Copy link
Collaborator Author

@AhmetNSimsek are the new commits meant to address #568 (comment) ?

Indeed! I forgot to ping you, sorry.

@AhmetNSimsek AhmetNSimsek force-pushed the maint_featurenames_and_cfdata branch from 4bae557 to b8b3bff Compare March 18, 2024 10:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 51.64%. Comparing base (5a0e6b3) to head (8da694f).
Report is 492 commits behind head on main.

Files Patch % Lines
siibra/features/tabular/cortical_profile.py 40.00% 24 Missing ⚠️
siibra/features/feature.py 40.74% 16 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 45.45% 12 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 23.07% 10 Missing ⚠️
...a/features/connectivity/functional_connectivity.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #568       +/-   ##
===========================================
+ Coverage   36.81%   51.64%   +14.82%     
===========================================
  Files          61       74       +13     
  Lines        5421     7012     +1591     
===========================================
+ Hits         1996     3621     +1625     
+ Misses       3425     3391       -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- `Compoundable._merge_elements` takes elements of a compound features and creates a feature of the same type to be used for averaged data and plotting.
- Averaging implies that the data is derived so when it is accessed the first time, this will be conveyed to the user. Also, the figure titles will reflect the info (even if the user supplies a title)
@AhmetNSimsek AhmetNSimsek force-pushed the maint_featurenames_and_cfdata branch from 0179fc3 to c432a11 Compare April 10, 2024 09:26
@AhmetNSimsek AhmetNSimsek force-pushed the maint_featurenames_and_cfdata branch from 9413bed to e0db4ef Compare April 11, 2024 08:13
@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review April 11, 2024 08:14
@AhmetNSimsek AhmetNSimsek merged commit 0c69d3b into main Apr 26, 2024
31 of 50 checks passed
@AhmetNSimsek AhmetNSimsek deleted the maint_featurenames_and_cfdata branch April 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important maintenance Not a bug or breaking issue. Code maintenance related. urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants